Skip to content

asm: Match clang behavior for inlateout fixed register operands #103098

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Oct 15, 2022

We have 2 options for representing LLVM constraints for inlateout operands on a fixed register (e.g. r0): ={r0},0 or ={r0},{r0}.

This PR changes the behavior to the latter, which matches the behavior of Clang since https://reviews.llvm.org/D87279.

We have 2 options for representing LLVM constraints for `inlateout`
operands on a fixed register (e.g. `r0`): `={r0},0` or `={r0},{r0}`.

This PR changes the behavior to the latter, which matches the behavior
of Clang since https://reviews.llvm.org/D87279.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 15, 2022
@rust-highfive
Copy link
Contributor

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2022
@cjgillot
Copy link
Contributor

I don't know enough about asm to review this, sorry.
r? compiler

@rustbot rustbot assigned davidtwco and unassigned cjgillot Oct 27, 2022
@davidtwco
Copy link
Member

Likewise, maybe bjorn?

r? @bjorn3

@rustbot rustbot assigned bjorn3 and unassigned davidtwco Nov 1, 2022
@bjorn3
Copy link
Member

bjorn3 commented Nov 1, 2022

I don't know enough about LLVM to know why this would be beneficial/necessary, but it doesn't look like it would break anything either.

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 1, 2022

📌 Commit 6bfe7f0 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2022
@bors
Copy link
Collaborator

bors commented Nov 3, 2022

⌛ Testing commit 6bfe7f0 with merge 41812cc416495286dabb10d5270c92cc0b6c9e7f...

@bors
Copy link
Collaborator

bors commented Nov 3, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 3, 2022
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@Amanieu
Copy link
Member Author

Amanieu commented Nov 3, 2022

Network error
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2022
@bors
Copy link
Collaborator

bors commented Nov 4, 2022

⌛ Testing commit 6bfe7f0 with merge 47c008e...

@bors
Copy link
Collaborator

bors commented Nov 4, 2022

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing 47c008e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 4, 2022
@bors bors merged commit 47c008e into rust-lang:master Nov 4, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 4, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (47c008e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.9% [0.5%, 1.1%] 3
Regressions ❌
(secondary)
4.4% [4.4%, 4.4%] 1
Improvements ✅
(primary)
-0.5% [-0.5%, -0.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.5% [-0.5%, 1.1%] 4

Cycles

This benchmark run did not return any relevant results for this metric.

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
asm: Match clang behavior for inlateout fixed register operands

We have 2 options for representing LLVM constraints for `inlateout` operands on a fixed register (e.g. `r0`): `={r0},0` or `={r0},{r0}`.

This PR changes the behavior to the latter, which matches the behavior of Clang since https://reviews.llvm.org/D87279.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants