Try to say that memory outside the AM is always exposed #103106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-libs
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
Oct 21, 2022
RalfJung
reviewed
Oct 21, 2022
RalfJung
reviewed
Oct 21, 2022
|
LGTM, but let's involve @thomcc as well, also for the changes I suggested. |
This comment has been minimized.
This comment has been minimized.
|
Looks great. Thank you for clarifying this. r=me once you've sufficiently resolved the outstanding debate about how precise you want the wording to be. |
saethlin
force-pushed
the
from_exposed_docs
branch
from
55eefc1 to
f3bf1ad
Compare
|
Some changes occurred in src/tools/cargo cc @ehuss |
|
Dangit I did the thing |
Co-authored-by: Ralf Jung <post@ralfj.de>
saethlin
force-pushed
the
from_exposed_docs
branch
from
f3bf1ad to
0c3ae7d
Compare
RalfJung
reviewed
Oct 26, 2022
|
LGTM aside from the last nit, but let's also get a libs person to look at this. |
Co-authored-by: Ralf Jung <post@ralfj.de>
|
This is a great improvement, thanks. @bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 27, 2022
Try to say that memory outside the AM is always exposed cc `@Gankra` `@thomcc` I want to confidently tell people that they can use `from_exposed_addr` to get a pointer for doing MMIO and/or other hardware interactions done with volatile reads/writes at particular addresses outside the Rust AM. Currently, the docs indicate that would be UB. With this change, now the docs indicate that this is intended to be a valid use of `from_exposed_addr`. r? `@RalfJung`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 27, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#103035 (Even nicer errors from assert_unsafe_precondition) - rust-lang#103106 (Try to say that memory outside the AM is always exposed) - rust-lang#103475 (Make param index generation a bit more robust) - rust-lang#103525 (Move a wf-check into the site where the value is instantiated) - rust-lang#103564 (library: allow some unused things in Miri) - rust-lang#103586 (Process registered region obligation in `resolve_regions_with_wf_tys`) - rust-lang#103592 (rustdoc: remove redundant CSS selector `.notable-traits .notable`) - rust-lang#103593 (Remove an unused parser function (`Expr::returns`)) - rust-lang#103611 (Add test for issue 103574) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Gankra @thomcc
I want to confidently tell people that they can use
from_exposed_addrto get a pointer for doing MMIO and/or other hardware interactions done with volatile reads/writes at particular addresses outside the Rust AM. Currently, the docs indicate that would be UB.With this change, now the docs indicate that this is intended to be a valid use of
from_exposed_addr.r? @RalfJung