rustdoc: remove CSS @media (min-width: 701px)
#103164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jsha (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
The two rules within it can and should be done without the separate
media query:
* There ain't no rule saying a viewport can't be `700.5px` wide, since
hardware pixels can be finer than CSS pixels.
* The rule for the first example-wrap child should probably apply
on mobile.
* The rule for the source sidebar is overriden by the mobile rule
setting `max-width: 100vw`, so it can be merged with the rest
of the styles.
Since it's possible to have a 700.5px viewport width, the JS needs to not switch to mobile mode in such a setup.
notriddle
force-pushed
the
notriddle/media-min-width
branch
from
b18c351 to
d4e4b08
Compare
notriddle
commented
Oct 18, 2022
| assert-css: (".sidebar", {"display": "block", "left": "-1000px"}) | ||
|
|
||
| // Scroll down. | ||
| scroll-to: "//h2[@id='blanket-implementations']" | ||
| assert-window-property: {"pageYOffset": "651"} | ||
| assert-window-property: {"pageYOffset": "627"} |
There was a problem hiding this comment.
This would benefit from a store-window-property command.
There was a problem hiding this comment.
GuillaumeGomez
approved these changes
Oct 18, 2022
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 18, 2022
…h, r=GuillaumeGomez
rustdoc: remove CSS `@media (min-width: 701px)`
The two rules within it can and should be done without the separate media query:
* There ain't no rule saying a viewport can't be `700.5px` wide, since hardware pixels can be finer than CSS pixels.
<details><summary>Screenshot</summary>
</details>
* The rule for the first example-wrap child should probably apply on mobile.
<details><summary>Screenshots</summary>
## Before
## After
</details>
* The rule for the source sidebar is overriden by the mobile rule setting `max-width: 100vw`, so it can be merged with the rest of the styles.
This was referenced Oct 18, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 19, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#101889 (doc: rewrite doc for uint::{carrying_add,borrowing_sub}) - rust-lang#102507 (More slice::partition_point examples) - rust-lang#103164 (rustdoc: remove CSS ``@media` (min-width: 701px)`) - rust-lang#103189 (Clean up code-color and headers-color rustdoc GUI tests) - rust-lang#103203 (Retrieve LLVM version from llvm-filecheck binary if it is not set yet) - rust-lang#103204 (Add some more autolabels) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two rules within it can and should be done without the separate media query:
There ain't no rule saying a viewport can't be
700.5pxwide, since hardware pixels can be finer than CSS pixels.Screenshot
The rule for the first example-wrap child should probably apply on mobile.
Screenshots
Before
After
The rule for the source sidebar is overriden by the mobile rule setting
max-width: 100vw, so it can be merged with the rest of the styles.