Skip to content

Clean up query descriptions #103182

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

Noratrieb
Copy link
Member

Use the same tense everywhere and prefer display over debug, as these descriptions are user facing.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 18, 2022
@rust-highfive
Copy link
Contributor

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2022
@rust-log-analyzer

This comment has been minimized.

@oli-obk
Copy link
Contributor

oli-obk commented Oct 18, 2022

You'll also need to bless some ui tests

@Noratrieb Noratrieb marked this pull request as draft October 18, 2022 09:46
@rust-log-analyzer

This comment has been minimized.

Use the same tense everywhere and prefer display over debug, as these
descriptions are user facing.
@Noratrieb Noratrieb marked this pull request as ready for review October 18, 2022 15:31
@@ -448,7 +448,7 @@ rustc_queries! {
) {
no_hash
desc {
|tcx| "processing {}`{}`",
|tcx| "processing MIR for {}`{}`",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this one is actually just about promoteds. But it's a pure caching query that does no work. Maybe we could even make it a regular function. Either way, seems ok as a weird name and doesn't really help or hinder anyone reading the cycle error

@oli-obk
Copy link
Contributor

oli-obk commented Oct 18, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 18, 2022

📌 Commit 4ed8345 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 19, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#102863 (Standardize "use parentheses to call" suggestions between typeck and trait selection)
 - rust-lang#103034 (Let expressions on RHS shouldn't be terminating scopes)
 - rust-lang#103127 (Make transpose const and inline)
 - rust-lang#103153 (Allow `Vec::leak` when using `no_global_oom_handling`)
 - rust-lang#103182 (Clean up query descriptions)
 - rust-lang#103216 (Consider patterns in fn params in an `Elided(Infer)` lifetime rib.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 02d6135 into rust-lang:master Oct 19, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 19, 2022
@Noratrieb Noratrieb deleted the query-desc-cleanup branch October 19, 2022 13:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants