-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Clarify startup #103230
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Clarify startup #103230
Conversation
- Make the structure of the two variants more similar. - Add some comments. - Move various conditional `use` items inside the function that uses them. - Inline some closures.
It took me a while to work this out.
@bors r+
This hurts performance, right, because we have to start a thread even for very small programs? Does it make sense to avoid using a thread pool for the non-parallel compiler? We can use |
I haven't measured, but I'd be surprised (horrified) if the cost of spawning one thread is significant even on the smallest programs. |
@bors rollup=always |
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#103221 (Fix `SelfVisitor::is_self_ty` ICE) - rust-lang#103230 (Clarify startup) - rust-lang#103281 (Adjust `transmute{,_copy}` to be clearer about which of `T` and `U` is input vs output) - rust-lang#103288 (Fixed docs typo in `library/std/src/time.rs`) - rust-lang#103296 (+/- shortcut now only expand/collapse, not both) - rust-lang#103297 (fix typo) - rust-lang#103313 (Don't label `src/test` tests as `A-testsuite`) - rust-lang#103315 (interpret: remove an incorrect assertion) - rust-lang#103319 (Improve "`~const` is not allowed here" message) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
A small follow-up to #102769.
r? @jyn514