Escape string literals when fixing overlong char literal #103354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
A-diagnostics
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Also fixing the case of |
|
Hm, this doesn't handle the case where we have already have an escaped literal like |
|
Also, can you remove the intermediate commits like 51f2826f7fc866c29842cc541684dd6ce066ba88 where you tried something and it didn't end up working out? It's not useful to keep those in the commit history, imo. |
clubby789
force-pushed
the
escape-string-literals
branch
from
57c443e to
8762485
Compare
|
Thanks @bors r+ rollup |
bors
added
S-waiting-on-bors
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Oct 22, 2022
…r=compiler-errors Escape string literals when fixing overlong char literal Fixes rust-lang#103323 `@rustbot` label +A-diagnostics +A-suggestion-diagnostics
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Oct 22, 2022
…r=compiler-errors Escape string literals when fixing overlong char literal Fixes rust-lang#103323 ``@rustbot`` label +A-diagnostics +A-suggestion-diagnostics
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 22, 2022
…r=compiler-errors Escape string literals when fixing overlong char literal Fixes rust-lang#103323 ```@rustbot``` label +A-diagnostics +A-suggestion-diagnostics
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 23, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#103123 (Introduce `subst_iter` and `subst_iter_copied` on `EarlyBinder` ) - rust-lang#103328 (Do not suggest trivially false const predicates) - rust-lang#103354 (Escape string literals when fixing overlong char literal) - rust-lang#103355 (Handle return-position `impl Trait` in traits properly in `register_hidden_type`) - rust-lang#103368 (Delay ambiguity span bug in normalize query iff not rustdoc) - rust-lang#103388 (rustdoc: remove unused CSS class `.result-description`) - rust-lang#103399 (Change `unknown_lint` applicability to `MaybeIncorrect`) - rust-lang#103401 (Use functions for headings rustdoc GUI test) - rust-lang#103412 (Fix typo in docs of `String::leak`.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103323
@rustbot label +A-diagnostics +A-suggestion-diagnostics