Skip to content

rustdoc: remove unused CSS .out-of-band { font-weight: normal } #103370

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

notriddle
Copy link
Contributor

This CSS was added in 083c395 to normalize the appearance of out-of-band elements that were nested directly below headers.

Now, the only use of out-of-band is in the main page header, and it is nested below a wrapper, not the <h1> itself.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 21, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 21, 2022
@notriddle notriddle force-pushed the notriddle/out-of-band branch from 62f8869 to 9e75385 Compare October 21, 2022 21:12
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Oct 21, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@notriddle notriddle force-pushed the notriddle/out-of-band branch from 9e75385 to 033becc Compare October 21, 2022 21:13
This CSS was added in 083c395 to
normalize the appearance of out-of-band elements that were nested directly
below headers.

Now, the only use of `out-of-band` is in the main page header, and it is
nested below a wrapper, not the `<h1>` itself.
@notriddle notriddle force-pushed the notriddle/out-of-band branch from 033becc to 1adb4c3 Compare October 21, 2022 21:13
@notriddle
Copy link
Contributor Author

r? @GuillaumeGomez

@notriddle notriddle removed the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Oct 21, 2022
@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass.

@notriddle
Copy link
Contributor Author

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 21, 2022

📌 Commit 1adb4c3 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2022
@notriddle
Copy link
Contributor Author

@bors r-

@bors r=GuillaumeGomez rollup

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 21, 2022
@bors
Copy link
Collaborator

bors commented Oct 21, 2022

📌 Commit 1adb4c3 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 21, 2022
notriddle added a commit to notriddle/rust that referenced this pull request Oct 21, 2022
…=GuillaumeGomez

rustdoc: remove unused CSS `.out-of-band { font-weight: normal }`

This CSS was added in 083c395 to normalize the appearance of out-of-band elements that were nested directly below headers.

Now, the only use of `out-of-band` is in the main page header, and it is nested below a wrapper, not the `<h1>` itself.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 21, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#102635 (make `order_dependent_trait_objects` show up in future-breakage reports)
 - rust-lang#103335 (Replaced wrong test with the correct mcve)
 - rust-lang#103339 (Fix some typos)
 - rust-lang#103340 (WinConsole::new is not actually fallible)
 - rust-lang#103341 (Add test for issue 97607)
 - rust-lang#103351 (Require Drop impls to have the same constness on its bounds as the bounds on the struct have)
 - rust-lang#103359 (Remove incorrect comment in `Vec::drain`)
 - rust-lang#103364 (rustdoc: clean up rustdoc-toggle CSS)
 - rust-lang#103370 (rustdoc: remove unused CSS `.out-of-band { font-weight: normal }`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1d3aa7b into rust-lang:master Oct 22, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 22, 2022
@notriddle notriddle deleted the notriddle/out-of-band branch October 22, 2022 04:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants