Emit a nicer error on impl Self {
#103609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-translation
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
|
☔ The latest upstream changes (presumably #103623) made this pull request unmergeable. Please resolve the merge conflicts. |
estebank
approved these changes
Oct 27, 2022
| @@ -137,3 +137,5 @@ hir_analysis_expected_used_symbol = expected `used`, `used(compiler)` or `used(l | |||
| hir_analysis_missing_parentheses_in_range = can't call method `{$method_name}` on type `{$ty_str}` | |||
|
|
|||
| hir_analysis_add_missing_parentheses_in_range = you must surround the range in parentheses to call its `{$func_name}` function | |||
|
|
|||
| hir_analysis_self_in_impl_self = `Self` is not valid at this location | |||
There was a problem hiding this comment.
Suggested change
| hir_analysis_self_in_impl_self = `Self` is not valid at this location | |
| hir_analysis_self_in_impl_self = `Self` is not valid in the `impl` type |
There was a problem hiding this comment.
Can we add a span label pointing at the Self on its own with the text "not valid at this location"?
There was a problem hiding this comment.
I think that we cant since #[note] spans: MultiSpan is an error, I think the errors are also relatively clear as to what the problematic location is even without that span being there so its not a huge loss. 🤔
|
pls squash as well |
BoxyUwU
force-pushed
the
fix_impl_self_cycle
branch
from
23ef6f9 to
c00ff9c
Compare
|
r=me after amending the last commit with a newline on the ftl file |
|
Im not sure im supposed to r=you this since i also resolved your review about splitting the visitor instead a separate fn and you didnt mention r+ing this after doing that 😆 |
compiler-errors
changed the title
impl Self {impl Self {
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 28, 2022
…piler-errors
Emit a nicer error on `impl Self {`
currently it emits a "cycle detected error" but this PR makes it emit a more user friendly error specifically saying that `Self` is disallowed in that position. this is a pretty hacky fix so i dont expect this to be merged (I basically only made this PR because i wanted to see if CI passes)
r? `@compiler-errors`
This was referenced Oct 28, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 28, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#103585 (Migrate source line numbers CSS to CSS variables) - rust-lang#103608 (Remap early bound lifetimes in return-position `impl Trait` in traits too) - rust-lang#103609 (Emit a nicer error on `impl Self {`) - rust-lang#103631 (Add test for issue 36007) - rust-lang#103643 (rustdoc: stop hiding focus outlines on non-rustdoc-toggle details tags) - rust-lang#103645 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently it emits a "cycle detected error" but this PR makes it emit a more user friendly error specifically saying that
Selfis disallowed in that position. this is a pretty hacky fix so i dont expect this to be merged (I basically only made this PR because i wanted to see if CI passes)r? @compiler-errors