Unhide unknown spans #103970
Merged
Unhide unknown spans #103970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
A-translation
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
davidtwco
approved these changes
Nov 7, 2022
|
r? @davidtwco @bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 7, 2022
…vidtwco Unhide unknown spans r? `@estebank`
bors
added
S-waiting-on-author
estebank
reviewed
Nov 8, 2022
oli-obk
commented
Nov 8, 2022
compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
Outdated
Show resolved
Hide resolved
It will still be used in json, as seen by the ui test changes
oli-obk
force-pushed
the
unhide_unknown_spans
branch
from
9268133 to
df2adc4
Compare
|
I re-added the label, but avoid emitting it in case of dummy spans. |
Makes sense! Now I'm intrigued as to why some of those where DUMMY_SP to begin with, nothing I saw in the previous tests gave me the impression they'd be, but I'm ok with proactive checking. The whole diagnostics machinery should treat all spans as @bors r+ |
bors
added
S-waiting-on-bors
|
Yea... the idents should have spans, but I didn't quickly find anything so I opted for this instead. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 11, 2022
…tebank Unhide unknown spans r? `@estebank`
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 11, 2022
…tebank Unhide unknown spans r? ``@estebank``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 12, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#102049 (Add the `#[derive_const]` attribute) - rust-lang#103970 (Unhide unknown spans) - rust-lang#104206 (Remove `save_and_restore_in_snapshot_flag`, use `ObligationCtxt` more) - rust-lang#104214 (Emit error in `collecting_trait_impl_trait_tys` on mismatched signatures) - rust-lang#104267 (rustdoc: use checkbox instead of switch for settings toggles) - rust-lang#104302 (Update cargo) - rust-lang#104303 (UI tests can be assigned to T-compiler) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @estebank