Several query cleanups

[Noratrieb]

A few cleanups, mostly about naming in rustc_query_system.

r? @cjgillot

[bors]

☔ The latest upstream changes (presumably #104009) made this pull request unmergeable. Please resolve the merge conflicts.

[cjgillot]

Just one nit.
r=me after rebase.

[cjgillot]

If we really want to be consistent, this would be a Dcx for DepContext, but I don't mind.

[cjgillot]

Query system is perf sensitive. There shouldn't really be anything, but just in case:
@bors r+ rollup=never

[bors]

📌 Commit 6d26ea8 has been approved by cjgillot

It is now in the queue for this repository.

[bors]

⌛ Testing commit 6d26ea8 with merge 310880ff180830e77647aa6eacaca94f42ab201d...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

The job x86_64-apple-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

      Memory: 14 GB
      System Firmware Version: VMW71.00V.13989454.B64.1906190538
      Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
      SMC Version (system): 2.8f0
      Serial Number (system): VMNFZU8uy8KA
      Provisioning UDID: 4203018E-580F-C1B5-9525-B745CECA79EB

hw.ncpu: 3
hw.byteorder: 1234
---
[  0%] Built target RTLSanCommon.osx
[  0%] Built target RTSanitizerCommonLibc.osx
Consolidate compiler generated dependencies of target RTSanitizerCommonCoverage.osx
[ 57%] Built target RTSanitizerCommon.osx
lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.osx.dir/compiler_depend.make:751: *** multiple target patterns.  Stop.
[ 57%] Built target RTSanitizerCommonCoverage.osx
make[2]: *** [lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.osx.dir/all] Error 2
make[2]: *** [lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.osx.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
[ 57%] Built target RTInterception.osx
[ 57%] Built target RTInterception.osx
make[1]: *** [lib/lsan/CMakeFiles/clang_rt.lsan_osx_dynamic.dir/rule] Error 2
make: *** [clang_rt.lsan_osx_dynamic] Error 2
command did not execute successfully, got: exit status: 2


build script failed, must exit now', /Users/runner/.cargo/registry/src/github.heygears.com-1ecc6299db9ec823/cmake-0.1.48/src/lib.rs:975:5
 finished in 109.503 seconds
Build completed unsuccessfully in 0:43:07

[Noratrieb]

Looks spurious..

[Dylan-DPC]

@bors retry

[bors]

⌛ Testing commit 6d26ea8 with merge 6b23a7e...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 6b23a7e to master...

[rust-timer]

Finished benchmarking commit (6b23a7e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	7.6%	[7.6%, 7.6%]	1
Improvements ✅ (primary)	-0.9%	[-1.0%, -0.8%]	2
Improvements ✅ (secondary)	-3.3%	[-3.3%, -3.3%]	1
All ❌✅ (primary)	-0.4%	[-1.0%, 0.4%]	3

Cycles

This benchmark run did not return any relevant results for this metric.