Skip to content

Mark trait_upcasting feature no longer incomplete. #104117

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 12, 2022

Conversation

crlf0710
Copy link
Member

@crlf0710 crlf0710 commented Nov 7, 2022

This marks the trait_upcasting feature no longer incomplete since #101336 has been settled for a little while.

r? @jackh726

@crlf0710 crlf0710 added the F-trait_upcasting `#![feature(trait_upcasting)]` label Nov 7, 2022
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 7, 2022
@jackh726
Copy link
Member

jackh726 commented Nov 7, 2022

Hmm, I would have expected changes to tests?

@compiler-errors
Copy link
Member

Hmm, I would have expected changes to tests?

This is because all existing tests have allow(incomplete_features) (and allow doesn't work like expect) -- we should probably remove those with this change, too.

@jackh726
Copy link
Member

jackh726 commented Nov 7, 2022

yes - this is why I generally shy against allow(incomplete_features) in tests vs annotating with incomplete warning

@crlf0710
Copy link
Member Author

crlf0710 commented Nov 9, 2022

Ok, i will.

@crlf0710 crlf0710 force-pushed the update_feature_gate branch from 0bf9664 to 3074678 Compare November 10, 2022 16:35
@crlf0710
Copy link
Member Author

Updated tests.

@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 10, 2022

📌 Commit 3074678 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2022
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 10, 2022
…ckh726

Mark `trait_upcasting` feature no longer incomplete.

This marks the `trait_upcasting` feature no longer incomplete since rust-lang#101336 has been settled for a little while.

r? `@jackh726`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 10, 2022
…ckh726

Mark `trait_upcasting` feature no longer incomplete.

This marks the `trait_upcasting` feature no longer incomplete since rust-lang#101336 has been settled for a little while.

r? ``@jackh726``
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 11, 2022
…ckh726

Mark `trait_upcasting` feature no longer incomplete.

This marks the `trait_upcasting` feature no longer incomplete since rust-lang#101336 has been settled for a little while.

r? ``@jackh726``
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 11, 2022
…ckh726

Mark `trait_upcasting` feature no longer incomplete.

This marks the `trait_upcasting` feature no longer incomplete since rust-lang#101336 has been settled for a little while.

r? ```@jackh726```
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 11, 2022
…ckh726

Mark `trait_upcasting` feature no longer incomplete.

This marks the `trait_upcasting` feature no longer incomplete since rust-lang#101336 has been settled for a little while.

r? ````@jackh726````
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 12, 2022
…ckh726

Mark `trait_upcasting` feature no longer incomplete.

This marks the `trait_upcasting` feature no longer incomplete since rust-lang#101336 has been settled for a little while.

r? `````@jackh726`````
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 12, 2022
…llaumeGomez

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104110 (prevent uninitialized access in black_box for zero-sized-types)
 - rust-lang#104117 (Mark `trait_upcasting` feature no longer incomplete.)
 - rust-lang#104144 (Suggest removing unnecessary `.` to use a floating point literal)
 - rust-lang#104250 (Migrate no result page link color to CSS variables)
 - rust-lang#104261 (More accurately report error when formal and expected signature types differ)
 - rust-lang#104263 (Add a reference to ilog2 in leading_zeros integer docs)
 - rust-lang#104308 (Remove the old `ValidAlign` name)
 - rust-lang#104319 (Fix non clickable source link)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bef2da0 into rust-lang:master Nov 12, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 12, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
F-trait_upcasting `#![feature(trait_upcasting)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants