Skip to content

Use nominal_obligations_without_const in wf for FnDef #104180

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2022
Merged

Use nominal_obligations_without_const in wf for FnDef #104180

merged 1 commit into from
Nov 9, 2022

Conversation

fee1-dead
Copy link
Member

Fixes #104155.

@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2022

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 9, 2022
@fee1-dead
Copy link
Member Author

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned petrochenkov Nov 9, 2022
@inquisitivecrystal inquisitivecrystal added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 9, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Nov 9, 2022

@bors r+ p=1 regression fix

@bors
Copy link
Collaborator

bors commented Nov 9, 2022

📌 Commit b3a328e has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2022
@bors
Copy link
Collaborator

bors commented Nov 9, 2022

⌛ Testing commit b3a328e with merge d22c433...

@bors
Copy link
Collaborator

bors commented Nov 9, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing d22c433 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 9, 2022
@bors bors merged commit d22c433 into rust-lang:master Nov 9, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 9, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d22c433): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.5% [-3.0%, -1.8%] 4
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

@oli-obk oli-obk deleted the fix-wf-fndef branch November 9, 2022 11:47
@pnkfelix
Copy link
Member

@rustbot label beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 10, 2022
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 15, 2022
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.67.0, 1.66.0 Nov 15, 2022
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Nov 15, 2022
Merged
@Mark-Simulacrum Mark-Simulacrum added beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Nov 20, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2022
@bors
Auto merge of rust-lang#104447 - Mark-Simulacrum:beta-next, r=Mark-Si…
0040709 
…mulacrum

[beta] backport

*  Use nominal_obligations_without_const in wf for FnDef rust-lang#104180
*  Don't silently eat label before block in block-like expr rust-lang#103986
*  Revert "Update CI to use Android NDK r25b" rust-lang#104628
*  rustdoc: Resolve doc links in external traits having local impls rust-lang#104364
*  Use 64 bits for incremental cache in-file positions rust-lang#104164
*  rustdoc: Do not add external traits to the crate in register_res rust-lang#103649
*  Revert "Normalize opaques with escaping bound vars" rust-lang#103509
* Bump to released stable compiler
* [beta] Update cargo rust-lang#104486

r? `@Mark-Simulacrum`
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

Passing a non-const trait function item value to a const fn is no longer allowed in a constant context
9 participants
@fee1-dead @rustbot @oli-obk @bors @rust-timer @pnkfelix @Mark-Simulacrum @petrochenkov @inquisitivecrystal