RequiredConstsVisitor is not needed when error happens in mir_promoted

[chenyukang]

No description provided.

[rustbot]

r? @fee1-dead

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[compiler-errors]

Although not noted in the PR, I'm pretty sure this is a different strategy to solve #104209, which is also addressed in #104233. Not sure which is better strategy (I don't particularly care), but regardless this PR needs a "fixes ##" note and a UI test.

[chenyukang]

Although not noted in the PR, this is a different strategy to solve #104209, which is also addressed in #104233. Not sure which is better strategy (I don't particularly care), but regardless this PR needs a "fixes ##" note and a UI test.

Yes, I was investigating #104209, but this change can not fix that issue.
My next fix is same as you, but since you submitted a PR for that, I removed it to avoid conflict 😁

[compiler-errors]

Hm -- If this PR does not fix anything or change observable behavior, I think it should be closed then, since it's not useful on its own.

[chenyukang]

Ok, closing it.