Skip to content

Add rustc_deny_explicit_impl #104339

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2022
Merged

Add rustc_deny_explicit_impl #104339

merged 1 commit into from
Nov 15, 2022

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Nov 12, 2022 •
edited
Loading

Also adjust E0322 error message to be more general, since it's used for DiscriminantKind and Pointee as well.

Also add rustc_deny_explicit_impl on the Tuple and Destruct marker traits.

@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2022

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 12, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@compiler-errors
Copy link
Member Author

cc @fee1-dead, it's not intended for Destruct to have user-defined impls, right?

@fee1-dead
Copy link
Member

fee1-dead commented Nov 13, 2022 •
edited
Loading

yeah, I don't know if the trait system cares about it, but it is best to deny them

@fee1-dead
Copy link
Member

This is technically a breaking change. Should we do a crater run?

@fee1-dead
Copy link
Member

oh, it looks like this doesn't deny any trait on stable. nevermind.

cjgillot
cjgillot reviewed Nov 13, 2022
View reviewed changes
Copy link
Contributor

@cjgillot cjgillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not even a ui test change ✨
Just one drive-by and r=me

compiler/rustc_hir_analysis/src/coherence/mod.rs
)
.span_label(impl_header_span, "impl of `Unsize` not allowed")
.emit();
err.emit();
return;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just below, the code swallows feature gate for rustc_specialization_trait when unboxed_closures is enabled. Could you remove that also?

@compiler-errors compiler-errors force-pushed the rustc_deny_explicit_impl branch from 91fca17 to b5b6467 Compare November 14, 2022 03:29
@compiler-errors
Copy link
Member Author

@bors r=cjgillot

@bors
Copy link
Collaborator

bors commented Nov 14, 2022

📌 Commit b5b6467 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 15, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2022
@bors
Auto merge of rust-lang#104437 - matthiaskrgr:rollup-n5jdg9v, r=matth…
6d651a2 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#103439 (Show note where the macro failed to match)
 - rust-lang#103734 (Adjust stabilization version to 1.65.0 for wasi fds)
 - rust-lang#104148 (Visit attributes of trait impl items during AST validation)
 - rust-lang#104241 (Move most of unwind's build script to lib.rs)
 - rust-lang#104258 (Deduce closure signature from a type alias `impl Trait`'s supertraits)
 - rust-lang#104296 (Walk types more carefully in `ProhibitOpaqueTypes` visitor)
 - rust-lang#104309 (Slightly improve error message for invalid identifier)
 - rust-lang#104316 (Simplify suggestions for errors in generators.)
 - rust-lang#104339 (Add `rustc_deny_explicit_impl`)

Failed merges:

 - rust-lang#103484 (Add `rust` to `let_underscore_lock` example)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 55ff8bf into rust-lang:master Nov 15, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 15, 2022
@compiler-errors compiler-errors deleted the rustc_deny_explicit_impl branch August 11, 2023 20:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @fee1-dead @bors @cjgillot