Skip to content

diagnostics: suggest changing s@self::{macro}@::macro for exported #104347

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 21, 2023
Merged

diagnostics: suggest changing s@self::{macro}@::macro for exported #104347

merged 4 commits into from
Jan 21, 2023

Conversation

notriddle
Copy link
Contributor

Fixes #99695

@rustbot
Copy link
Collaborator

rustbot commented Nov 13, 2022

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 13, 2022
@notriddle notriddle force-pushed the notriddle/import-macro-from-self-fixup branch from 9528386 to cf2d0ce Compare November 13, 2022 04:48
@notriddle notriddle added the A-diagnostics Area: Messages for errors, warnings, and lints label Nov 18, 2022
TaKO8Ki
TaKO8Ki reviewed Dec 6, 2022
View reviewed changes
Copy link
Member

@TaKO8Ki TaKO8Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late replay. I left some comments.

@TaKO8Ki
Copy link
Member

TaKO8Ki commented Dec 6, 2022

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2022
@notriddle
Copy link
Contributor Author

@TaKO8Ki Those were both good calls. Thanks! I've pushed fixes.

@notriddle
Copy link
Contributor Author

@rustbot reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 6, 2022
@notriddle notriddle force-pushed the notriddle/import-macro-from-self-fixup branch from 8bc281f to f2070c3 Compare December 6, 2022 15:50
@apiraino
Copy link
Contributor

Friendly ping for a review @TaKO8Ki . Thanks!

@TaKO8Ki
Copy link
Member

TaKO8Ki commented Jan 20, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 20, 2023

📌 Commit f2070c3 has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 20, 2023
@compiler-errors
Rollup merge of rust-lang#104347 - notriddle:notriddle/import-macro-f…
993932b 
…rom-self-fixup, r=TaKO8Ki

diagnostics: suggest changing `s@self::{macro}@::macro` for exported

Fixes rust-lang#99695
@compiler-errors compiler-errors mentioned this pull request Jan 20, 2023
Closed
@compiler-errors
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 20, 2023
@notriddle notriddle force-pushed the notriddle/import-macro-from-self-fixup branch from f2070c3 to c07a722 Compare January 20, 2023 21:53
@notriddle
Copy link
Contributor Author

@TaKO8Ki @compiler-errors

Rebased onto the master branch with the tests moved into /tests/

@compiler-errors
Copy link
Member

@bors r=TaKO8Ki

@bors
Copy link
Collaborator

bors commented Jan 20, 2023

📌 Commit c07a722 has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 20, 2023
@compiler-errors compiler-errors mentioned this pull request Jan 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 21, 2023
@bors
Auto merge of rust-lang#107143 - compiler-errors:rollup-zabvmo5, r=co…
e098eb1 
…mpiler-errors

Rollup of 9 pull requests

Successful merges:

 - rust-lang#104154 (Change `bindings_with_variant_name` to deny-by-default)
 - rust-lang#104347 (diagnostics: suggest changing `s@self::{macro}`@::macro`` for exported)
 - rust-lang#104672 (Unify stable and unstable sort implementations in same core module)
 - rust-lang#107048 (check for x version updates)
 - rust-lang#107061 (Implement some more new solver candidates and fix some bugs)
 - rust-lang#107095 (rustdoc: remove redundant CSS selector `.sidebar .current`)
 - rust-lang#107112 (Fix typo in opaque_types.rs)
 - rust-lang#107124 (fix check macro expansion)
 - rust-lang#107131 (rustdoc: use CSS inline layout for radio line instead of flexbox)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bf75f81 into rust-lang:master Jan 21, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 21, 2023
@notriddle notriddle deleted the notriddle/import-macro-from-self-fixup branch January 21, 2023 07:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@TaKO8Ki TaKO8Ki TaKO8Ki left review comments

Assignees

@TaKO8Ki TaKO8Ki

Labels
A-diagnostics Area: Messages for errors, warnings, and lints S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

import #[macro_export] from crate root help broken by use trees
6 participants
@notriddle @rustbot @TaKO8Ki @apiraino @bors @compiler-errors