-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Make more Result
methods const
#104407
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Make more Result
methods const
#104407
Conversation
Constified methods: Result::{map, map_or, map_or_else, map_err, as_deref, as_deref_mut, unwrap_or_default, and_then, or_else, unwrap_or_else, unwrap_unchecked, unwrap_err_unchecked, copied, cloned}
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. Please see the contribution instructions for more information. |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
@rustbot label: +T-libs-api -T-libs +A-const-fn |
r? @thomcc |
☔ The latest upstream changes (presumably #114250) made this pull request unmergeable. Please resolve the merge conflicts. |
I think even in our new process an ACP is needed for this? You can file one here https://github.com/rust-lang/libs-team/ |
@netsutetsu any updates on the ACP? |
I'm going to be away for a few months, so I'm rerolling my PRs so that folks don't have to wait for me. Sorry/thanks. r? libs |
Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks |
Tracking issue: #82814
Constified methods: Result::{map, map_or, map_or_else, map_err, as_deref, as_deref_mut, unwrap_or_default, and_then, or_else, unwrap_or_else, unwrap_unchecked, unwrap_err_unchecked, copied, cloned}