Migrate rustc_mir_build diagnostics

[mejrs]

Rebases #100854

The remaining issue is how to better resolve 72bea68

The diagnostic macros seems to generate a broken diagnostic, and I couldn't figure out how to manually format the fluent message, so I hardcoded the format string for now. I'd like pointers to a better fix for this.

Also, I'm not 100% sure I didn't mess up a rebase somewhere 🙂

r? @davidtwco

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @davidtwco (or someone else) soon.

Please see the contribution instructions for more information.

[rustbot]

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

[davidtwco]

The remaining issue is how to better resolve 72bea68

The diagnostic macros seems to generate a broken diagnostic, and I couldn't figure out how to manually format the fluent message, so I hardcoded the format string for now. I'd like pointers to a better fix for this.

You should be able to fix this by using #[subdiagnostic(eager)] where this subdiagnostic is used.

[mejrs]

You should be able to fix this by using #[subdiagnostic(eager)] where this subdiagnostic is used.

Ah that's good to know. I've fixed that and rebased.

[davidtwco]

You can try using the list support added in #104047, maybe better as a follow-up so we can land this though.

[davidtwco]

Apologies for the delay in getting back to this.

@bors r+

[bors]

📌 Commit 2354697 has been approved by davidtwco

It is now in the queue for this repository.

[Manishearth]

@bors r-

#104790 (comment)

[bors]

☔ The latest upstream changes (presumably #104809) made this pull request unmergeable. Please resolve the merge conflicts.

[mejrs]

Rebased

@rustbot ready

[jyn514]

@bors r=davidtwco

[bors]

📌 Commit 1d324dd has been approved by davidtwco

It is now in the queue for this repository.

[mejrs]

I think this fixes the ice that was hit during rollup, but I'm not sure how to test it locally.

[mejrs]

I think this works on dist-riscv64-linux now - see https://github.com/rust-lang/rust/actions/runs/3721937031/jobs/6312424723

[Noratrieb]

@bors r=davidtwco
Let's hope it really works now

[bors]

📌 Commit f7e894c has been approved by davidtwco

It is now in the queue for this repository.

[bors]

⌛ Testing commit f7e894c with merge 35a99ee...

[bors]

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 35a99ee to master...

[rust-timer]

Finished benchmarking commit (35a99ee): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.0%	[1.0%, 1.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.3%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	1.3%	[1.3%, 1.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.3%	[2.3%, 2.3%]	1

Cycles

This benchmark run did not return any relevant results for this metric.