Skip to content

Update PROBLEMATIC_CONSTS in style.rs #104471

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Update PROBLEMATIC_CONSTS in style.rs #104471

merged 1 commit into from
Nov 16, 2022

Conversation

scruss
Copy link
Contributor

@scruss scruss commented Nov 16, 2022

added 3735932941, since 3735927486 was already present.

added 3735932941, since 3735927486 was already present.
@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jyn514 (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2022
@jyn514
Copy link
Member

jyn514 commented Nov 16, 2022

#100925 (comment)

Is it common to use this hex sequence? My understanding is that we're avoiding sequences that were previously common to use as examples; there are too many slurs for us to ban the hex representation of every single one of them.

@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2022
@scruss
Copy link
Contributor Author

scruss commented Nov 16, 2022

It's the Dalvik VM abort code. No more or less offensive/profane than others on the list. But if you're going to block the obsolete magic number for IRIX arena files, you should block this one too on equity grounds.

References:

  1. Android JNI: root-causing deadd00d (dvmAbort)
  2. How do I find relevant deadd00d circumstances from customer devices?

@jyn514
Copy link
Member

jyn514 commented Nov 16, 2022

Thanks for the explanation!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 16, 2022

📌 Commit e6e29a8 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 16, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 16, 2022
Update PROBLEMATIC_CONSTS in style.rs

added 3735932941, since 3735927486 was already present.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 16, 2022
Update PROBLEMATIC_CONSTS in style.rs

added 3735932941, since 3735927486 was already present.
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 16, 2022
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#103484 (Add `rust` to `let_underscore_lock` example)
 - rust-lang#103489 (Make `pointer::byte_offset_from` more generic)
 - rust-lang#104193 (Shift no characters when using raw string literals)
 - rust-lang#104348 (Respect visibility & stability of inherent associated types)
 - rust-lang#104401 (avoid memory leak in mpsc test)
 - rust-lang#104419 (Fix test/ui/issues/issue-30490.rs)
 - rust-lang#104424 (rustdoc: remove no-op CSS `.popover { font-size: 1rem }`)
 - rust-lang#104425 (rustdoc: remove no-op CSS `.main-header { justify-content }`)
 - rust-lang#104450 (Fuchsia test suite script fix)
 - rust-lang#104471 (Update PROBLEMATIC_CONSTS in style.rs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8bbecb9 into rust-lang:master Nov 16, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 16, 2022
@scruss scruss deleted the patch-1 branch November 16, 2022 16:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants