Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add -Zexport-executable-symbols to unstable book #104549

Merged

Conversation

folkertdev
Copy link
Contributor

This flag has been extremely useful to me, but it's hard to discover. The text contains a bunch of terms that hopefully a search engine will pick up on when someone searches for this functionality.

@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 17, 2022
@rust-log-analyzer

This comment has been minimized.

@folkertdev folkertdev force-pushed the unstable-book-export-executable-symbols branch from 90e38d9 to f83f5b1 Compare November 17, 2022 21:41
@rust-log-analyzer

This comment has been minimized.

@folkertdev folkertdev force-pushed the unstable-book-export-executable-symbols branch from f83f5b1 to f53b364 Compare November 19, 2022 13:48
@GuillaumeGomez
Copy link
Member

It needs someone from the compiler team to review this.

r? t-compiler

@rustbot
Copy link
Collaborator

rustbot commented Mar 2, 2023

Failed to set assignee to t-compiler: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@GuillaumeGomez
Copy link
Member

r? rust-lang/compiler

@WaffleLapkin
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 3, 2023

📌 Commit f53b364 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 3, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2023
@WaffleLapkin
Copy link
Member

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104549 (add -Zexport-executable-symbols to unstable book)
 - rust-lang#108292 (Label opaque type for 'captures lifetime' error message)
 - rust-lang#108540 (Add `Atomic*::from_ptr`)
 - rust-lang#108634 (Add link to component dashboard)
 - rust-lang#108647 (Remove dead pgo.sh file)
 - rust-lang#108678 (Use `Option::as_slice` where applicable)
 - rust-lang#108681 (Improve comments in `needs_process_obligation`.)
 - rust-lang#108688 (Match unmatched backticks in library/)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a8b9f47 into rust-lang:master Mar 4, 2023
@rustbot rustbot added this to the 1.69.0 milestone Mar 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants