Remove a lifetime resolution hack from compare_predicate_entailment
#104701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 22, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#104295 (Check generics parity before collecting return-position `impl Trait`s in trait) - rust-lang#104464 (Reduce exceptions overallocation on non Windows x86_64) - rust-lang#104615 (Create def_id for async fns during lowering) - rust-lang#104669 (Only declare bindings for if-let guards once per arm) - rust-lang#104701 (Remove a lifetime resolution hack from `compare_predicate_entailment`) - rust-lang#104710 (disable strict-provenance-violating doctests in Miri) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not needed anymore, probably due to #102334 equating the function signatures fully in
collect_trait_impl_trait_tys. Also, the assertion in in #102903 makes sure that this is actually fixed, so I'm pretty confident this isn't needed.