Skip to content

Add failing test for projections used as const generic #104717

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

GuillaumeGomez
Copy link
Member

Based on the experiment done in #104443, we realized it's currently not possible to support projections in const generics. More information about it in #104443 (comment).

This PR adds the UI test in any case so we can gather data in order to work towards adding TyAlias into the ABI in the future.

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 22, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Nov 22, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 22, 2022

📌 Commit 2d5d692 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2022
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 22, 2022
…d-as-const-generic, r=oli-obk

Add failing test for projections used as const generic

Based on the experiment done in rust-lang#104443, we realized it's currently not possible to support projections in const generics. More information about it in rust-lang#104443 (comment).

This PR adds the UI test in any case so we can gather data in order to work towards adding `TyAlias` into the ABI in the future.

r? `@oli-obk`
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 22, 2022
…d-as-const-generic, r=oli-obk

Add failing test for projections used as const generic

Based on the experiment done in rust-lang#104443, we realized it's currently not possible to support projections in const generics. More information about it in rust-lang#104443 (comment).

This PR adds the UI test in any case so we can gather data in order to work towards adding `TyAlias` into the ABI in the future.

r? ```@oli-obk```
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 22, 2022
Rollup of 7 pull requests

Successful merges:

 - rust-lang#101368 (Forbid inlining `thread_local!`'s `__getit` function on Windows)
 - rust-lang#102293 (Add powerpc64-ibm-aix as Tier-3 target)
 - rust-lang#104717 (Add failing test for projections used as const generic)
 - rust-lang#104720 (rustdoc: remove no-op CSS `.popover::before / a.test-arrow { display: inline-block }`)
 - rust-lang#104722 (Speed up mpsc_stress test)
 - rust-lang#104724 (Fix `ClosureKind::to_def_id`)
 - rust-lang#104728 (Use `tcx.require_lang_item` instead of unwrapping lang items)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ecf2536 into rust-lang:master Nov 23, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 23, 2022
@GuillaumeGomez GuillaumeGomez deleted the test-projection-used-as-const-generic branch November 23, 2022 10:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants