Skip to content

Remove AscribeUserTypeCx #104906

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Nov 26, 2022
Merged

Conversation

spastorino
Copy link
Member

@spastorino spastorino commented Nov 25, 2022

r? @compiler-errors

This basically inlines AscribeUserTypeCx::relate_mir_and_user_ty into type_op_ascribe_user_type_with_span which is the only place where it's used and makes direct use of ObligationCtxt API.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 25, 2022
@spastorino spastorino force-pushed the remove-ascribeusertypecx branch from 5e882bd to 00f4ddf Compare November 25, 2022 18:41
@compiler-errors
Copy link
Member

r=me

@spastorino spastorino force-pushed the remove-ascribeusertypecx branch from 00f4ddf to e511839 Compare November 25, 2022 19:00
@spastorino spastorino force-pushed the remove-ascribeusertypecx branch from e511839 to 3c9b30e Compare November 25, 2022 19:00
@spastorino
Copy link
Member Author

@bors r=compiler-errors rollup

@bors
Copy link
Collaborator

bors commented Nov 25, 2022

📌 Commit 3c9b30e has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 26, 2022
…x, r=compiler-errors

Remove AscribeUserTypeCx

r? `@compiler-errors`

This basically inlines `AscribeUserTypeCx::relate_mir_and_user_ty` into `type_op_ascribe_user_type_with_span` which is the only place where it's used and makes direct use of `ObligationCtxt` API.
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 26, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#104121 (Refine `instruction_set` MIR inline rules)
 - rust-lang#104675 (Unsupported query error now specifies if its unsupported for local or external crate)
 - rust-lang#104839 (improve array_from_fn documenation)
 - rust-lang#104880 ([llvm-wrapper] adapt for LLVM API change)
 - rust-lang#104899 (rustdoc: remove no-op CSS `#help dt { display: block }`)
 - rust-lang#104906 (Remove AscribeUserTypeCx)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1fe18a5 into rust-lang:master Nov 26, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants