Rollup of 7 pull requests #104945
Merged
Rollup of 7 pull requests #104945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This accomplishes the same thing with significantly less code.
…ler-errors Use the power of adding helper function to simplify code w/ `Mutability` r? `@compiler-errors`
…en, r=fee1-dead Do not record unresolved const vars in generator interior Don't record types in the generator interior when we see unresolved const variables. We already do this for associated types -- this is important to avoid unresolved inference variables in the generator results during writeback, since the writeback results get stable hashed in incremental mode. Fixes rust-lang#104787
…ypes-is-misleading, r=fee1-dead Rename `normalize_opaque_types` to `reveal_opaque_types_in_bounds` 1. The query name is a bit misleading, since it doesn't do any associated type normalization, and 2. since it only takes a predicate list, it sounds a bit more powerful than it actually is.
…y, r=cjgillot Remove unnecessary binder from `get_impl_future_output_ty` We never construct an `async fn` with a higher-ranked `impl Future` bound anyways, and basically all the call-sites already skip the binder.
…s, r=GuillaumeGomez jsondoclint: Accept trait alias is places where trait expected. More work to make `jsondoclint` work for `core.json` Closes rust-lang#104923 r? `@GuillaumeGomez` `@rustbot` modify labels: +A-testsuite
…-flexbox, r=GuillaumeGomez rustdoc: use flexbox CSS to align sidebar button instead of position This accomplishes the same thing with significantly less code. Preview: https://notriddle.com/notriddle-rustdoc-demos/sidebar-toggle-flexbox/src/test_dingus/lib.rs.html
…, r=GuillaumeGomez jsondoclint: Handle using enum variants and glob using enums. More work on jsondoclint for `core.json` Closes rust-lang#104942 r? `@GuillaumeGomez` `@rustbot` modify labels: +A-testsuite
rustbot
added
A-rustdoc-json
|
@bors r+ p=7 rollup=never |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 80a96467ec In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
📌 Perf builds for each rolled up PR: previous master: c3a1c023c0 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (80a9646): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Mutability#104786 (Use the power of adding helper function to simplify code w/Mutability)normalize_opaque_typestoreveal_opaque_types_in_bounds#104909 (Renamenormalize_opaque_typestoreveal_opaque_types_in_bounds)get_impl_future_output_ty#104921 (Remove unnecessary binder fromget_impl_future_output_ty)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup