Skip to content

Assign myself for docs updates #104992

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 27, 2022

This sets myself as the reviewer for docs submodule updates. Now with rust-lang/triagebot#1673 automating the process, this piece of the puzzle handles the assignment step.

This sets myself as the reviewer for docs submodule updates.
Now with rust-lang/triagebot#1673 automating
the process, this piece of the puzzle handles the assignment step.
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 27, 2022

📌 Commit be18880 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2022
@Mark-Simulacrum
Copy link
Member

@bors p=1

@bors
Copy link
Collaborator

bors commented Nov 28, 2022

⌛ Testing commit be18880 with merge db77a040761de295cdb47175e0383e052ca32372...

@bors
Copy link
Collaborator

bors commented Nov 28, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 28, 2022
@Dylan-DPC
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Nov 28, 2022

⌛ Testing commit be18880 with merge f0a4175625b6fdc4459f59abab9e1d8286412a31...

@bors
Copy link
Collaborator

bors commented Nov 28, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 28, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@ehuss
Copy link
Contributor Author

ehuss commented Nov 28, 2022

@bors retry

Second time in a row that x86_64-gnu hung while doing the initial update of the crates.io index. A very strange coincidence.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 28, 2022
…k-Simulacrum

Assign myself for docs updates

This sets myself as the reviewer for docs submodule updates. Now with rust-lang/triagebot#1673 automating the process, this piece of the puzzle handles the assignment step.
@bors
Copy link
Collaborator

bors commented Nov 29, 2022

⌛ Testing commit be18880 with merge 60b8fc4...

@bors
Copy link
Collaborator

bors commented Nov 29, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 60b8fc4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 29, 2022
@bors bors merged commit 60b8fc4 into rust-lang:master Nov 29, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 29, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (60b8fc4): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.9% [0.9%, 0.9%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.1% [-1.1%, -1.1%] 1
All ❌✅ (primary) 0.9% [0.9%, 0.9%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.3% [-3.3%, -3.3%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
…Simulacrum

Assign myself for docs updates

This sets myself as the reviewer for docs submodule updates. Now with rust-lang/triagebot#1673 automating the process, this piece of the puzzle handles the assignment step.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants