Skip to content

Fix expr_to_spanned_string ICE #105078

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2022
Merged

Fix expr_to_spanned_string ICE #105078

merged 2 commits into from
Dec 1, 2022

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Nov 30, 2022

Fixes #105011

@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2022

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 30, 2022
Rageking8
Rageking8 reviewed Nov 30, 2022
View reviewed changes
@compiler-errors
Copy link
Member

compiler-errors commented Nov 30, 2022 •
edited
Loading

r? @nnethercote you are more familiar with this I think, feel free to hand back the PR to me. looks good to me, though.

@nnethercote
Copy link
Contributor

Looks great!

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 30, 2022

📌 Commit 02eaecc has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2022
@nnethercote
Copy link
Contributor

@bors rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 1, 2022
@matthiaskrgr
Rollup merge of rust-lang#105078 - TaKO8Ki:fix-105011, r=nnethercote
c181999 
Fix `expr_to_spanned_string` ICE

Fixes rust-lang#105011
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 1, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Dec 1, 2022
@Dylan-DPC
Rollup merge of rust-lang#105078 - TaKO8Ki:fix-105011, r=nnethercote
7a7b885 
Fix `expr_to_spanned_string` ICE

Fixes rust-lang#105011
@Dylan-DPC Dylan-DPC mentioned this pull request Dec 1, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 1, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 1, 2022
@bors
Auto merge of rust-lang#105125 - matthiaskrgr:rollup-fr0snmj, r=matth…
c090c68 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#105078 (Fix `expr_to_spanned_string` ICE)
 - rust-lang#105087 (Extract llvm datalayout parsing out of spec module)
 - rust-lang#105088 (rustdoc: remove redundant CSS `div.desc { display: block }`)
 - rust-lang#105106 (Fix ICE from rust-lang#105101)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 741f8c9 into rust-lang:master Dec 1, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 1, 2022
@TaKO8Ki TaKO8Ki deleted the fix-105011 branch December 7, 2022 04:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Rageking8 Rageking8 Rageking8 left review comments

Assignees

@nnethercote nnethercote

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

ICE when invalid string literal used with macro
6 participants
@TaKO8Ki @rustbot @compiler-errors @nnethercote @bors @Rageking8