Properly substitute inherent associated types. #105224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Looks good to me! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 4, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#101975 (Suggest to use . instead of :: when accessing a method of an object) - rust-lang#105141 (Fix ICE on invalid variable declarations in macro calls) - rust-lang#105224 (Properly substitute inherent associated types.) - rust-lang#105236 (Add regression test for rust-lang#47814) - rust-lang#105247 (Use parent function WfCheckingContext to check RPITIT.) - rust-lang#105253 (Update a couple of rustbuild deps) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Thanks! Does it handle inherent GATs (seeing you only subst. the params from the ADT) or should I open a new issue? E.g. the following ICEs on nightly: #![feature(inherent_associated_types)]
struct S;
impl S { type P<T> = T }
fn main() { let _: S::P<()> = (); } |
I've just checked and it does handle them correctly which is absolutely awesome! |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 5, 2022
…errors Normalize inherent associated types after substitution Fixes rust-lang#105314. r? `@cjgillot` (rust-lang#105224) `@rustbot` label F-inherent_associated_types
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 5, 2022
…errors Normalize inherent associated types after substitution Fixes rust-lang#105314. r? ``@cjgillot`` (rust-lang#105224) ``@rustbot`` label F-inherent_associated_types
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 5, 2022
…errors Normalize inherent associated types after substitution Fixes rust-lang#105314. r? ```@cjgillot``` (rust-lang#105224) ```@rustbot``` label F-inherent_associated_types
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Dec 6, 2022
…errors Normalize inherent associated types after substitution Fixes rust-lang#105314. r? ````@cjgillot```` (rust-lang#105224) ````@rustbot```` label F-inherent_associated_types
3 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104240