Skip to content

Recurse into nested impl-trait when computing variance. #105254

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Dec 4, 2022

Fixes #105251

@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2022

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 4, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Dec 4, 2022

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned petrochenkov Dec 4, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Dec 5, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 5, 2022

📌 Commit 44948d1 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 5, 2022
Recurse into nested impl-trait when computing variance.

Fixes rust-lang#105251
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 5, 2022
Recurse into nested impl-trait when computing variance.

Fixes rust-lang#105251
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 5, 2022
Recurse into nested impl-trait when computing variance.

Fixes rust-lang#105251
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 6, 2022
Recurse into nested impl-trait when computing variance.

Fixes rust-lang#105251
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 6, 2022
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#104439 (Add prototype to generate `COPYRIGHT` from REUSE metadata)
 - rust-lang#105005 (On E0195 point at where clause lifetime bounds)
 - rust-lang#105098 (propagate the error from parsing enum variant to the parser and emit out)
 - rust-lang#105243 (remove no-op 'let _ = ')
 - rust-lang#105254 (Recurse into nested impl-trait when computing variance.)
 - rust-lang#105287 (Synthesize substitutions for bad auto traits in dyn types)
 - rust-lang#105310 (Be more careful about unresolved exprs in suggestion)
 - rust-lang#105318 (Make `get_impl_future_output_ty` work with AFIT)
 - rust-lang#105339 (support `ConstKind::Expr` in `is_const_evaluatable` and `WfPredicates::compute`)
 - rust-lang#105340 (Avoid ICE by accounting for missing type)
 - rust-lang#105342 (Make `note_obligation_cause_code`  take a `impl ToPredicate` for predicate)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ddb98e0 into rust-lang:master Dec 6, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 6, 2022
@cjgillot cjgillot deleted the issue-105251 branch December 6, 2022 15:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nested rpit allows capturing illegal lifetimes
5 participants