Account for match expr in single line
#105347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
This could use a test, though I guess it's not critical. |
When encountering `match Some(42) { Some(x) => x, None => "" };`, output
```
error[E0308]: `match` arms have incompatible types
--> f53.rs:2:52
|
2 | let _ = match Some(42) { Some(x) => x, None => "" };
| -------------- - ^^ expected integer, found `&str`
| | |
| | this is found to be of type `{integer}`
| `match` arms have incompatible types
```
estebank
force-pushed
the
single-line-match
branch
from
72e34e1 to
05e8ba1
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 28, 2022
…fee1-dead Rollup of 9 pull requests Successful merges: - rust-lang#94145 (Test leaking of BinaryHeap Drain iterators) - rust-lang#103945 (Remove `iter::Empty` hack) - rust-lang#104024 (Fix `unused_must_use` warning for `Box::from_raw`) - rust-lang#104708 (Fix backoff doc to match implementation) - rust-lang#105347 (Account for `match` expr in single line) - rust-lang#105484 (Implement allow-by-default `multiple_supertrait_upcastable` lint) - rust-lang#106184 (Fix `core::any` docs) - rust-lang#106201 (Emit fewer errors on invalid `#[repr(transparent)]` on `enum`) - rust-lang#106205 (Remove some totally duplicated files in `rustc_infer`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encountering
match Some(42) { Some(x) => x, None => "" };, output