Skip to content

update stdarch #105784

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 27, 2023
Merged

update stdarch #105784

merged 3 commits into from
Jan 27, 2023

Conversation

yanns
Copy link
Contributor

@yanns yanns commented Dec 16, 2022

This will allow using miri on simd instructions
rust-lang/stdarch#1347 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2022

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 16, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@yanns yanns mentioned this pull request Dec 16, 2022
Closed
@Amanieu
Copy link
Member

Amanieu commented Dec 16, 2022

cc @calebzulawski Any idea why this is failing? I would have thought your PR #103750 makes this work.

@calebzulawski
Copy link
Member

It looks like std is built with the beta compiler, which doesn't have those changes yet

@Amanieu
Copy link
Member

Amanieu commented Dec 16, 2022

The beta compiler should have been updated just last week though, so I would expect it to include these changes.

@Amanieu Amanieu self-assigned this Dec 16, 2022
@calebzulawski
Copy link
Member

The log shows downloading the beta compiler from Nov 1, that sounds like 1.66 rather than 1.67

@Amanieu
Copy link
Member

Amanieu commented Dec 16, 2022

Blocked on #105741.

@Amanieu Amanieu added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2022
@rust-log-analyzer

This comment has been minimized.

# to view
@Amanieu
Copy link
Member

Amanieu commented Dec 29, 2022

#105741 is now merged, can you rebase?

@yanns
update stdarch
a538723 
This will allow using miri on simd instructions
rust-lang/stdarch#1347 (comment)
@rust-log-analyzer

This comment has been minimized.

# to view
@yanns
Copy link
Contributor Author

yanns commented Dec 30, 2022

@Amanieu Do you have an idea why it is failing? Can I help somehow?

@calebzulawski
Copy link
Member

Those errors are due to changes from #100752. Some feature names have been deprecated in the is_x86_feature_detected macro. I added allow(deprecated) to the tests that use the old names, though...

@calebzulawski
Copy link
Member

calebzulawski commented Jan 4, 2023 •
edited
Loading

Ah actually, as part of this update, this file needs to change too:

rust/library/std/tests/run-time-detect.rs

Line 123 in c757267

println!("avx512gfni: {:?}", is_x86_feature_detected!("avx512gfni"));

rust/library/std/tests/run-time-detect.rs

Line 126 in c757267

println!("avx512vaes: {:?}", is_x86_feature_detected!("avx512vaes"));

rust/library/std/tests/run-time-detect.rs

Line 132 in c757267

println!("avx512vpclmulqdq: {:?}", is_x86_feature_detected!("avx512vpclmulqdq"));

avx512gfni, avx512vaes, and avx512vpclmulqdq should all have the avx512 prefix removed.

@hkratz hkratz mentioned this pull request Jan 26, 2023
Closed
@yanns
Copy link
Contributor Author

yanns commented Jan 26, 2023 •
edited
Loading

@calebzulawski thanks for the help. The CI checks are passing now.

@Amanieu
Copy link
Member

Amanieu commented Jan 26, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 26, 2023

📌 Commit 2e8162a has been approved by Amanieu

It is now in the queue for this repository.

@bors bors removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jan 26, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 26, 2023
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 27, 2023
@JohnTitor
Rollup merge of rust-lang#105784 - yanns:update_stdarch, r=Amanieu
a5a8b48 
update stdarch

This will allow using miri on simd instructions
rust-lang/stdarch#1347 (comment)
@JohnTitor JohnTitor mentioned this pull request Jan 27, 2023
Closed
@JohnTitor JohnTitor mentioned this pull request Jan 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 27, 2023
@bors
Auto merge of rust-lang#107343 - JohnTitor:rollup-s6l94aj, r=JohnTitor
18890f0 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#105784 (update stdarch)
 - rust-lang#106856 (core: Support variety of atomic widths in width-agnostic functions)
 - rust-lang#107171 (rustc_metadata: Fix `encode_attrs`)
 - rust-lang#107242 (rustdoc: make item links consistently use `title="{shortty} {path}"`)
 - rust-lang#107279 (Use new solver during selection)
 - rust-lang#107284 (rustdoc: use smarter encoding for playground URL)
 - rust-lang#107325 (rustdoc: Stop using `HirId`s)
 - rust-lang#107336 (rustdoc: remove mostly-unused CSS classes `import-item` and `module-item`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4b4aeae into rust-lang:master Jan 27, 2023
@rustbot rustbot added this to the 1.69.0 milestone Jan 27, 2023
@yanns yanns deleted the update_stdarch branch January 27, 2023 09:33
@taiki-e taiki-e mentioned this pull request Feb 10, 2023
Merged
bors bot added a commit to taiki-e/portable-atomic that referenced this pull request Feb 11, 2023
@bors @taiki-e
Merge #76
10c1a09 
76: detect: Workaround Exynos 9810 bug on aarch64 Android r=taiki-e a=taiki-e

Samsung Exynos 9810 has a bug that big and little cores have different ISAs. And on older Android (pre-9), the kernel incorrectly reports that features available only on some cores are available on all cores.

See https://reviews.llvm.org/D114523 for details.

Our own run-time detection code has not been released yet and is not a problem, but portable-atomic < 1.1 may have been affected by this issue since rustc 1.69-nightly when is_aarch64_feature_detected supported run-time detection on Android. (rust-lang/stdarch#1351, rust-lang/rust#105784)

A patch on stdarch side: rust-lang/stdarch#1378

Co-authored-by: Taiki Endo <te316e89@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
7 participants
@yanns @rustbot @Amanieu @calebzulawski @rust-log-analyzer @bors @m-ou-se