Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update Clippy #105827

Merged
merged 101 commits into from
Dec 17, 2022
Merged

Update Clippy #105827

merged 101 commits into from
Dec 17, 2022

Conversation

flip1995
Copy link
Member

xFrednet and others added 30 commits November 21, 2022 23:28
@xFrednet
Cleanup rustc_tool_util and add a convenient macro for build.rs
aa66212
@Veykril
Add semicolon-outside/inside-block lints
93b5c89
@Veykril
Fix formatting of let chains
ba951e3
@Veykril
Use multi-span suggestions
23744cd
@Veykril
Fix macro statement handling
dd1163f
@Veykril
Address reviews
ab41546
@Veykril
Adjust semicolon block lint descriptions
f585414
@Veykril
Adjust description once more
f62eab4
@naosense
add suppress_lint_in_const conf
96f1385
@naosense
add test and stderr
aed9497
@naosense
update config and suggest
4528aec
@naosense
resolve conflicts
c9bf4b7
@naosense
change default value
1fc98c5
@naosense
change note style
67a9413
@mdgaziur
Fix rust-lang#9958
7a0f0c0
@Jarcho
Don't suggest keeping borrows in identity_op
03ba0ea
@Jarcho
Don't suggest removing mut from references in `redundant_static_lif…
55096ea 
…etimes`
@Jarcho
Treat custom enum discriminant values as constants
a1b15f1
@petrochenkov
rustc_hir: Relax lifetime requirements on Visitor::visit_path
4f8c49e
@petrochenkov
rustc_hir: Change representation of import paths to support multiple …
9314e5b 
…resolutions
@petrochenkov
rustc_ast_lowering: Stop lowering imports into multiple items
b0d490e 
Lower them into a single item with multiple resolutions instead.
This also allows to remove additional `NodId`s and `DefId`s related to those additional items.
@Jarcho
Don't lint from_over_into for opaque types
6ecdff0
@flip1995
Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup
d05e286
@alex-semenyuk
Fix manual_let_else produces a wrong suggestion with or-patterns
05477ff
@Jarcho
Don't lint string_lit_as_bytes in match scrutinees
a21b5b2
@bors
Auto merge of rust-lang#10012 - Jarcho:issue_9885, r=Alexendoo
3b8a10c 
Don't lint `string_lit_as_bytes` in match scrutinees

fixes rust-lang#9885
changelog: `string_lit_as_bytes`: Don't lint in match scrutinees
@bors
Auto merge of rust-lang#9966 - alex-semenyuk:manual_let_else_paren, r…
53e1b45 
…=xFrednet

Fix manual_let_else produces a wrong suggestion with or-patterns

Fix rust-lang#9938
changelog: Sugg: [`manual_let_else`]: Suggestions for or-patterns now include required brackets.
[rust-lang#9966](rust-lang/rust-clippy#9966)
@bors
Auto merge of rust-lang#10006 - Jarcho:issue_9890, r=Manishearth
be0eb20 
Don't suggest removing `mut` from references in `redundant_static_lifetimes`

fixes rust-lang#9890
changelog: `redundant_static_lifetimes`: Don't suggest removing `mut` from references
@bors
Auto merge of rust-lang#10008 - Jarcho:issue_9882, r=Manishearth
e16a8b9 
Treat custom enum discriminant values as constants

fixes rust-lang#9882
changelog: All lints: Don't lint in enum discriminant values when the suggestion won't work in a const context
@Jarcho
Don't lint manual_assert in else if
47fb67f
nbdd0121 and others added 13 commits December 15, 2022 18:56
@nbdd0121
Fix new_return_no_self with recursive bounds
7574c98
@matthiaskrgr
Rollup merge of rust-lang#105743 - nnethercote:SimplifiedType-cleanup…
cfe1e04 
…s, r=lcnr

`SimplifiedType` cleanups

r? `@lcnr`
@bors
Auto merge of rust-lang#10086 - nbdd0121:master, r=matthiaskrgr
02f3959 
Fix new_return_no_self with recursive bounds

Fix rust-lang#10041

This uses a hash set, as described in rust-lang/rust-clippy#10068 (comment)

changelog: [`new_return_no_self`]: fix stack overflow when the return type is `impl Trait` and contains recursive bounds
@ericwu17
fix logic in IncrementVisitor
97c12e0 
There used to be a logical bug where IncrementVisitor would
completely stop checking an expression/block after seeing a continue
statement. This led to issue rust-lang#10058 where a variable incremented
(or otherwise modified) after any continue statement would still be
considered incremented only once.

The solution is to continue scanning the expression after seeing a
`continue` statement, but increment self.depth so that the Visitor
thinks that the rest of the loop is within a conditional.
@bors
Auto merge of rust-lang#10094 - EricWu2003:increment-visitor-fix, r=x…
b62319c 
…Frednet

fix logic in IncrementVisitor

There used to be a logical bug where IncrementVisitor would completely stop checking an expression/block after seeing a continue statement.

I am a little unsure of whether my fix to `IncrementVisitor` is logically sound (I hope it makes sense). Let me know what you think, and thanks in advance for the review!

fixes rust-lang#10058

---

changelog: FP: [`explicit_counter_loop`]: No longer ignores counter changes after `continue` expressions
[rust-lang#10094](rust-lang/rust-clippy#10094)
<!-- changelog_checked -->
@feniljain
fix: not suggest seek_to_start_instead_of_rewind when expr is used
c39849a
@bors
Auto merge of rust-lang#10096 - feniljain:fix-seek-rewind, r=xFrednet
391b2a6 
fix: not suggest seek_to_start_instead_of_rewind when expr is used

changelog: [`seek_to_start_instead_of_rewind`]: No longer lints, if the return of `seek` is used.
[rust-lang#10096](rust-lang/rust-clippy#10096)
<!-- changelog_checked -->

Fixes rust-lang#10065
@flip1995
Merge remote-tracking branch 'upstream/master' into rustup
d6488ae
@flip1995
Bump Clippy version -> 0.1.68
1f1d23c
@flip1995
Bump nightly version -> 2022-12-17
7198989
@bors
Auto merge of rust-lang#10097 - flip1995:rustup, r=flip1995
4bdfb07 
Rustup

r? `@ghost`

I'm on the train and my internet is too bad to download the necessary toolchain, so I have to use CI to find sync fallout.

changelog: none
<!-- changelog_checked -->
@flip1995
Merge commit '4bdfb0741dbcecd5279a2635c3280726db0604b5' into clippyup
adb8ba3
@flip1995
Update Cargo.lock
10f2a6d
@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@matthiaskrgr
Copy link
Member

@bors r+ p=1 subtree sync

@bors
Copy link
Contributor

bors commented Dec 17, 2022

📌 Commit 10f2a6d has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2022
@bors
Copy link
Contributor

bors commented Dec 17, 2022

⌛ Testing commit 10f2a6d with merge 2d76a9d...

@bors
Copy link
Contributor

bors commented Dec 17, 2022

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 2d76a9d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 17, 2022
@bors bors merged commit 2d76a9d into rust-lang:master Dec 17, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 17, 2022
@bors bors mentioned this pull request Dec 17, 2022
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2d76a9d): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.3% [-0.3%, -0.3%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.7% [1.1%, 2.6%] 5
Improvements ✅
(primary)		 -3.3% [-3.3%, -3.3%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.3% [-3.3%, -3.3%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

@eddyb eddyb mentioned this pull request Jan 5, 2023
Merged
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 20, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.