use &str / String literals instead of format!() #105873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nagisa (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-translation
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki Some changes occurred in cc @BoxyUwU |
Noratrieb
reviewed
Dec 18, 2022
| span, | ||
| format!("Missing value for constant, but no error reported?"), | ||
| ); | ||
| let guar = infcx |
There was a problem hiding this comment.
Interesting how rustfmt changed its heuristics here, I guess the long macro was keeping it from doing this (arguably the old formatting was better imo but whatever, can't change that).
|
r? @Nilstrieb @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 19, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#105419 (Add tests for rust-lang#41731) - rust-lang#105447 (Add a test for rust-lang#103095) - rust-lang#105842 (print argument name in arg mismatch if possible) - rust-lang#105863 (Update browser-ui-test version to reduce GUI tests flakyness) - rust-lang#105867 (remove redundant fn params that were only "used" in recursion) - rust-lang#105869 (don't clone Copy types) - rust-lang#105873 (use &str / String literals instead of format!()) - rust-lang#105879 (Revert "Introduce lowering_arena to avoid creating AST nodes on the fly") Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.