Skip to content

Rollup of 7 pull requests #105876

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 14 commits into from
Dec 18, 2022
Merged

Rollup of 7 pull requests #105876

merged 14 commits into from
Dec 18, 2022

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

tmiasko and others added 14 commits December 16, 2022 00:00
- Remove setup special-casing in Flags::parse
I really liked this structure that dtolney brought up in rust-lang#105316, so wanted to put it in the docs to help others use it.
This removes another python search from bootstrap.
… r=jyn514

Fix `x setup -h -v` should work

r? `@jyn514`

I have to convert profile to path and back in order to remove special-casing in bootstrap. I also check for `dry_run` so that `config.toml` and/ or `.git/hooks/pre-push` will not be created if `--dry-run` is specified.

Please help me see if this is ok, thanks alot!
…obDegen

Remove dead code after destination propagation

Fixes rust-lang#105428.

cc `@JakobDegen`
Make the x tool use the x and x.ps1 scripts

This removes another python search from bootstrap.

r? `@jyn514`
…r=the8472

Another `as_chunks` example

I really liked this structure that dtolney brought up in rust-lang#105316, so wanted to put it in the docs to help others use it.
avoid .into() conversion to identical types
…erence, r=oli-obk

don't destuct references just to reborrow
@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 18, 2022
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=7

@bors
Copy link
Collaborator

bors commented Dec 18, 2022

📌 Commit 2237977 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2022
@bors
Copy link
Collaborator

bors commented Dec 18, 2022

⌛ Testing commit 2237977 with merge d0dc9ef...

@bors
Copy link
Collaborator

bors commented Dec 18, 2022

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing d0dc9ef to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 18, 2022
@bors bors merged commit d0dc9ef into rust-lang:master Dec 18, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 18, 2022
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#105875 419c7eb29b923aa04c42e805943e5cf94d940ae6
#105870 843b505ba8287d82e876ffa8e5515b4a5fe31370
#105858 89b8f13ebaefc2432092ac0f71b15afff2ab6de5
#105854 79a31c9488731e236fc0f85b92b0b8c972ebd69f
#105844 af1bf42360f4d55a569d46c6ed7bf09d3d740916
#105420 1eeec4f60f7f56f76cef7c7d1f32ff95d38aa192
#96584 d0df63ba35fbba04a8e2552be4b418b9c2c2d5f8

previous master: 37efc81072

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d0dc9ef): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.7% [-1.8%, -1.6%] 6
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.3% [-1.3%, -1.3%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.3% [-1.3%, -1.3%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

@matthiaskrgr matthiaskrgr deleted the rollup-a9dgzjt branch December 22, 2022 10:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants