Skip to content

Stabilize path_as_mut_os_str #105962

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2023
Merged

Stabilize path_as_mut_os_str #105962

merged 1 commit into from
Mar 11, 2023

Conversation

zertosh
Copy link
Contributor

@zertosh zertosh commented Dec 20, 2022

Closes #105021

r? @dtolnay

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 20, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@zertosh
Copy link
Contributor Author

zertosh commented Dec 20, 2022

@rustbot label +T-libs-api -T-lib

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 20, 2022
@zertosh
Copy link
Contributor Author

zertosh commented Dec 20, 2022

@rustbot label -T-libs

@rustbot rustbot removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Dec 20, 2022
@dtolnay dtolnay added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2022
@dtolnay
Copy link
Member

dtolnay commented Feb 28, 2023

Triage: still waiting on FCP in #105021.

@dtolnay dtolnay added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. labels Mar 10, 2023
@dtolnay
Copy link
Member

dtolnay commented Mar 10, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 10, 2023

📌 Commit 5b7ab80 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2023
@matthiaskrgr
Rollup merge of rust-lang#105962 - zertosh:stabilize_path_as_mut_os_s…
ce44d93 
…tr, r=dtolnay

Stabilize path_as_mut_os_str

Closes rust-lang#105021

r? `@dtolnay`
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 10, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2023
@matthiaskrgr
Rollup merge of rust-lang#105962 - zertosh:stabilize_path_as_mut_os_s…
b4ebfeb 
…tr, r=dtolnay

Stabilize path_as_mut_os_str

Closes rust-lang#105021

r? ``@dtolnay``
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 10, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 10, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2023
@bors
Auto merge of rust-lang#109001 - matthiaskrgr:rollup-a3agnwp, r=matth…
e350fe4 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#105798 (Relax ordering rules for `asm!` operands)
 - rust-lang#105962 (Stabilize path_as_mut_os_str)
 - rust-lang#106085 (use problem matchers for tidy CI)
 - rust-lang#107711 (Stabilize movbe target feature)
 - rust-lang#108017 (Add `--no-undefined-version` link flag and fix associated breakage)
 - rust-lang#108891 (Remove an extraneous include)
 - rust-lang#108902 (no more do while :<)
 - rust-lang#108912 (Document tool lints)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a69a9b3 into rust-lang:master Mar 11, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 11, 2023
@zertosh zertosh deleted the stabilize_path_as_mut_os_str branch March 11, 2023 12:10
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Mar 15, 2023
@bors
Auto merge of rust-lang#109001 - matthiaskrgr:rollup-a3agnwp, r=matth…
7e23d77 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#105798 (Relax ordering rules for `asm!` operands)
 - rust-lang#105962 (Stabilize path_as_mut_os_str)
 - rust-lang#106085 (use problem matchers for tidy CI)
 - rust-lang#107711 (Stabilize movbe target feature)
 - rust-lang#108017 (Add `--no-undefined-version` link flag and fix associated breakage)
 - rust-lang#108891 (Remove an extraneous include)
 - rust-lang#108902 (no more do while :<)
 - rust-lang#108912 (Document tool lints)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

Tracking issue for PathBuf::as_mut_os_string and Path::as_mut_os_str
4 participants
@zertosh @rustbot @dtolnay @bors