Sort lint_groups in no_lint_suggestion #106008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nilstrieb (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Ah, the dangers of I think it makes more sense to just filter out deprecated lint groups, they are not what people should use so we shouldn't suggest them. |
The no_lint_suggestion routine passes a vector of lint group names to find_best_match_for_name. That routine depends on the sort order of its input vector, which matters in case multiple inputs are at the same Levenshtein distance to the target name. However, no_lint_suggestion currently just passes lint_groups.keys() as input vector - this is sorted in hash value order, which is not guaranteed to be stable, and in fact differs between big- and little-endian host platforms, causing test failures on s390x. To fix this, always sort the lint groups before using their names as input to find_best_match_for_name. In addition, deprecated lint groups should never be suggested, so filter those out. Fixes rust-lang#105379
uweigand
force-pushed
the
s390x-lintgroup-order
branch
from
e2c9528 to
30fbfd5
Compare
Agreed, patch updated accordingly. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 22, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#105584 (add assert messages if chunks/windows are length 0) - rust-lang#105602 (interpret: add read_machine_[ui]size convenience methods) - rust-lang#105824 (str.lines() docstring: clarify that line endings are not returned) - rust-lang#105980 (Refer to "Waker" rather than "RawWaker" in `drop` comment) - rust-lang#105986 (Fix typo in reading_half_a_pointer.rs) - rust-lang#105995 (Add regression test for rust-lang#96530) - rust-lang#106008 (Sort lint_groups in no_lint_suggestion) - rust-lang#106014 (Add comment explaining what the scrape-examples-toggle.goml GUI test is about) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…Nilstrieb Sort lint_groups in no_lint_suggestion The no_lint_suggestion routine passes a vector of lint group names to find_best_match_for_name. That routine depends on the sort order of its input vector, which matters in case multiple inputs are at the same Levenshtein distance to the target name. However, no_lint_suggestion currently just passes lint_groups.keys() as input vector - this is sorted in hash value order, which is not guaranteed to be stable, and in fact differs between big- and little-endian host platforms, causing test failures on s390x. To fix this, always sort the lint groups before using their names as input to find_best_match_for_name. In doing so, prefer non- deprecated lint group names over deprecated ones, and then use alphabetical order. Fixes rust-lang#105379
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
Rollup of 8 pull requests Successful merges: - rust-lang#105584 (add assert messages if chunks/windows are length 0) - rust-lang#105602 (interpret: add read_machine_[ui]size convenience methods) - rust-lang#105824 (str.lines() docstring: clarify that line endings are not returned) - rust-lang#105980 (Refer to "Waker" rather than "RawWaker" in `drop` comment) - rust-lang#105986 (Fix typo in reading_half_a_pointer.rs) - rust-lang#105995 (Add regression test for rust-lang#96530) - rust-lang#106008 (Sort lint_groups in no_lint_suggestion) - rust-lang#106014 (Add comment explaining what the scrape-examples-toggle.goml GUI test is about) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The no_lint_suggestion routine passes a vector of lint group names to find_best_match_for_name. That routine depends on the sort order of its input vector, which matters in case multiple inputs are at the same Levenshtein distance to the target name.
However, no_lint_suggestion currently just passes lint_groups.keys() as input vector - this is sorted in hash value order, which is not guaranteed to be stable, and in fact differs between big- and little-endian host platforms, causing test failures on s390x.
To fix this, always sort the lint groups before using their names as input to find_best_match_for_name. In doing so, prefer non- deprecated lint group names over deprecated ones, and then use alphabetical order.
Fixes #105379