Skip to content

Support x clean --stage 1 rustc_query_impl #106271

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 31, 2022
Merged

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 29, 2022

Previously, clean only supported --stage 0 for specific crates.

The new crate_description function generates a string that looks like

: {rustc_query_impl}

@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2022

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2022
Previously, clean only supported `--stage 0` for specific crates.

The new `crate_description` function generates a string that looks
like
```
: {rustc_query_impl}
```
@jyn514
Copy link
Member Author

jyn514 commented Dec 29, 2022

hmm, I just realized we also have another way of showing individual crates:

Testing ["rustc_interface"] stage0 (aarch64-unknown-linux-gnu -> aarch64-unknown-linux-gnu)

We should probably settle on one or the other.

@jyn514
Copy link
Member Author

jyn514 commented Dec 30, 2022

hmm, I just realized we also have another way of showing individual crates:

Testing ["rustc_interface"] stage0 (aarch64-unknown-linux-gnu -> aarch64-unknown-linux-gnu)

We should probably settle on one or the other.

This ended up being a little bigger of a change than I expected, I moved it to a separate PR: #106303

@Mark-Simulacrum
Copy link
Member

r=me, modulo whether rebasing over the other PR makes sense.

@bors bors merged commit cbede85 into rust-lang:master Dec 31, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 31, 2022
@jyn514 jyn514 deleted the stage1-clean branch February 25, 2023 18:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants