Win64 fixes #10631
Win64 fixes #10631
Conversation
|
I've manually built 64-bit rustc.exe using this script. However 64-bit one seems to work slowly. |
|
@klutzy do you have anyidea why it's so slow? |
| # pthreads works badly on mingw-w64 systems: #8996 | ||
| case "$CFG_BUILD" in | ||
| (*w64-mingw32) | ||
| LLVM_OPTS="$LLVM_OPTS --disable-pthreads" |
There was a problem hiding this comment.
I do not believe that we should be doing this change at this time without further modification. If it's slow, then that's a problem, but this is a soundness issue.
It is unsound to use rustc from multiple tasks in the same process if we do not pass this flag to LLVM.
There was a problem hiding this comment.
I think the flag only causes llvm to use win32 api for thread/critical section instead of pthreads api (there is separate --disable-threads option and it's not passed), but it definitely needs confirmation.
|
@cmr I just realized I've built it with |
|
I'm curious whether weak symbols work on mingw-w64 or whether they continue to not work. I'm not a fan of doing the lookup-by-maybe-a-leading-underscore-or-not method. With investigation into that, r=me |
This patchset fixes some parts broken on Win64. This also adds `--disable-pthreads` flags to llvm on mingw-w64 archs (both 32-bit and 64-bit, not mingw) due to bad performance. See #8996 for discussion.
… r=Alexendoo Standardize lint formulation Fixes rust-lang#10631 changelog: Standardize a very frequent lint formulation which had variations
"try this" -> "try" Current help messages contain a mix of "try", "try this", and one "try this instead". In the spirit of rust-lang#10631, this PR adopts the first, as it is the most concise. It also updates the `lint_message_conventions` test to catch cases of "try this". (Aside: rust-lang#10120 unfairly contained multiple changes in one PR. I am trying to break that PR up into smaller pieces.) changelog: Make help messages more concise ("try this" -> "try").
This patchset fixes some parts broken on Win64.
This also adds
--disable-pthreadsflags to llvm on mingw-w64 archs (both 32-bit and 64-bit, not mingw) due to bad performance. See #8996 for discussion.