Skip to content

error-code docs improvements (No. 2) #106614

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Conversation

Ezrashaw
Copy link
Contributor

@Ezrashaw Ezrashaw commented Jan 9, 2023

  • Added empty error-code docs for E0208, E0640 and E0717 with the "internal" header as discussed on Discord.
  • Wrote docs and UI test for E0711, again with the header.
  • tidy changes are common-sense and make everything pass, style.rs hack is annoying though.

r? @GuillaumeGomez

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 9, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2023

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@Ezrashaw Ezrashaw changed the title error-code docs improvements (#2) error-code docs improvements (No. 2) Jan 9, 2023
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 9, 2023

📌 Commit 2c92c72 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2023
JohnTitor pushed a commit to JohnTitor/rust that referenced this pull request Jan 9, 2023
…aumeGomez

error-code docs improvements (No. 2)

- Added empty error-code docs for `E0208`, `E0640` and `E0717` with the "internal" header as discussed on Discord.
- Wrote docs and UI test for `E0711`, again with the header.
- `tidy` changes are common-sense and make everything pass, `style.rs` hack is annoying though.

r? `@GuillaumeGomez`
JohnTitor pushed a commit to JohnTitor/rust that referenced this pull request Jan 9, 2023
…aumeGomez

error-code docs improvements (No. 2)

- Added empty error-code docs for `E0208`, `E0640` and `E0717` with the "internal" header as discussed on Discord.
- Wrote docs and UI test for `E0711`, again with the header.
- `tidy` changes are common-sense and make everything pass, `style.rs` hack is annoying though.

r? ``@GuillaumeGomez``
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2023
…fee1-dead

Rollup of 10 pull requests

Successful merges:

 - rust-lang#105292 (Change a commit_if_ok call to probe)
 - rust-lang#105655 (Remove invalid case for mutable borrow suggestion)
 - rust-lang#106047 (Fix ui constant tests for big-endian platforms)
 - rust-lang#106061 (Enable Shadow Call Stack for Fuchsia on AArch64)
 - rust-lang#106164 (Move `check_region_obligations_and_report_errors` to `TypeErrCtxt`)
 - rust-lang#106291 (Fix incorrect suggestion for extra `&` in pattern)
 - rust-lang#106389 (Simplify some canonical type alias names)
 - rust-lang#106468 (Use FxIndexSet when updating obligation causes in `adjust_fulfillment_errors_for_expr_obligation`)
 - rust-lang#106549 (Use fmt named parameters in rustc_borrowck)
 - rust-lang#106614 (error-code docs improvements (No. 2))

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 77f529b into rust-lang:master Jan 9, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 9, 2023
@Ezrashaw Ezrashaw deleted the ui-test-fixups-2 branch January 11, 2023 10:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants