Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a regression test for argument copies with DestinationPropagation #106660

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

saethlin
Copy link
Member

This example, as a codegen test: #105813 (comment)

r? @tmiasko

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2023
@saethlin saethlin force-pushed the destprop-move-codegen branch from e93cc8d to 1801611 Compare January 10, 2023 04:47
@tmiasko
Copy link
Contributor

tmiasko commented Jan 10, 2023

@bors r+ rollup=never codegen test

@bors
Copy link
Contributor

bors commented Jan 10, 2023

📌 Commit 1801611b314a4205ff89580ab7a4f05dceb929af has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2023
@bors
Copy link
Contributor

bors commented Jan 10, 2023

⌛ Testing commit 1801611b314a4205ff89580ab7a4f05dceb929af with merge a4bdc47796082ecd6160777c17fcca83c424a64c...

@bors
Copy link
Contributor

bors commented Jan 10, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 10, 2023
@rust-log-analyzer

This comment has been minimized.

@saethlin saethlin force-pushed the destprop-move-codegen branch from 1801611 to 4234757 Compare January 10, 2023 21:04
@saethlin
Copy link
Member Author

The alignment of u64 is 8 on 64-bit systems but 4 on 32-bit, so the codegen test failed on a 32-bit target. I switched T to [u8; 256].

@saethlin saethlin force-pushed the destprop-move-codegen branch from 4234757 to aa5e6c2 Compare January 10, 2023 21:08
@tmiasko
Copy link
Contributor

tmiasko commented Jan 10, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jan 10, 2023

📌 Commit aa5e6c2a7b3edec0fb9534b45164fc2a7a62e5c5 has been approved by tmiasko

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 10, 2023

🌲 The tree is currently closed for pull requests below priority 999. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2023
@JohnTitor JohnTitor mentioned this pull request Jan 11, 2023
9 tasks
@JohnTitor
Copy link
Member

A test file now has to be added to the tests dir on the root, see #106458
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 11, 2023
@tmiasko
Copy link
Contributor

tmiasko commented Jan 11, 2023

@bors delegate=saethlin

@bors
Copy link
Contributor

bors commented Jan 11, 2023

✌️ @saethlin can now approve this pull request

@saethlin saethlin force-pushed the destprop-move-codegen branch from aa5e6c2 to 13eec69 Compare January 11, 2023 15:32
@saethlin
Copy link
Member Author

@bors r=tmiasko rollup=never codegen test

@bors
Copy link
Contributor

bors commented Jan 11, 2023

📌 Commit 13eec69 has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 11, 2023
@bors
Copy link
Contributor

bors commented Jan 11, 2023

⌛ Testing commit 13eec69 with merge 1e4f900...

@bors
Copy link
Contributor

bors commented Jan 11, 2023

☀️ Test successful - checks-actions
Approved by: tmiasko
Pushing 1e4f900 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 11, 2023
@bors bors merged commit 1e4f900 into rust-lang:master Jan 11, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 11, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1e4f900): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.4% [2.0%, 4.6%] 10
Regressions ❌
(secondary)
2.3% [0.6%, 4.4%] 89
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.4% [-3.4%, -3.4%] 1
All ❌✅ (primary) 3.4% [2.0%, 4.6%] 10

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
23.0% [23.0%, 23.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

@saethlin saethlin mentioned this pull request Feb 11, 2023
@saethlin saethlin deleted the destprop-move-codegen branch March 15, 2023 00:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants