Skip to content

Report fulfillment errors in new trait solver #106705

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

compiler-errors
Copy link
Member

Causes fewer ICEs when testing the new solver 😄

@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 11, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2023

Some changes occurred to the core trait solver

cc @lcnr

Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, then r=me

@BoxyUwU BoxyUwU added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Jan 11, 2023
@compiler-errors compiler-errors force-pushed the new-solver-err-properly branch from ec9dfec to 104ec48 Compare January 11, 2023 18:06
@compiler-errors
Copy link
Member Author

@bors r=lcnr

@bors
Copy link
Collaborator

bors commented Jan 11, 2023

📌 Commit 104ec48 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 11, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#106620 (Detect struct literal needing parentheses)
 - rust-lang#106622 (Detect out of bounds range pattern value)
 - rust-lang#106703 (Note predicate span on `ImplDerivedObligation`)
 - rust-lang#106705 (Report fulfillment errors in new trait solver)
 - rust-lang#106726 (Fix some typos in code comments.)
 - rust-lang#106734 (Deny having src/test exisiting in tidy)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 865d83e into rust-lang:master Jan 12, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 12, 2023
@compiler-errors compiler-errors deleted the new-solver-err-properly branch August 11, 2023 20:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants