Skip to content

Add WaffleLapkin to compiler reviewers #106761

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2023
Merged

Add WaffleLapkin to compiler reviewers #106761

merged 1 commit into from
Jan 12, 2023

Conversation

WaffleLapkin
Copy link
Member

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jan 12, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 12, 2023

📌 Commit fb0ecc0 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2023
@Noratrieb Noratrieb mentioned this pull request Jan 12, 2023
Closed
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Jan 12, 2023
@Noratrieb
Rollup merge of rust-lang#106761 - WaffleLapkin:waffle-is-CompilerRev…
22d99d4 
…iewer, r=oli-obk

Add `WaffleLapkin` to compiler reviewers

r? `@wesleywiser`
@Noratrieb Noratrieb mentioned this pull request Jan 12, 2023
Merged
@wesleywiser
Copy link
Member

Thanks so much for adding yourself @WaffleLapkin! It's a huge help for all the existing reviewers 🥇

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 12, 2023
@bors
Auto merge of rust-lang#106773 - Nilstrieb:rollup-sq73pyg, r=Nilstrieb
1bc3683 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#105806 (Support eager subdiagnostics again)
 - rust-lang#106322 (Handle inference variables in `CollectAllMismatches` correctly)
 - rust-lang#106579 (Suggest making private tuple struct field public)
 - rust-lang#106714 (remove unreachable error code `E0490`)
 - rust-lang#106751 (Fix rendering 'const' in header for intrinsics)
 - rust-lang#106761 (Add `WaffleLapkin` to compiler reviewers)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 89f9569 into rust-lang:master Jan 12, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 12, 2023
@WaffleLapkin WaffleLapkin deleted the waffle-is-CompilerReviewer branch June 1, 2025 13:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@wesleywiser wesleywiser

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@WaffleLapkin @oli-obk @bors @wesleywiser @rustbot