Skip to content

Remove redundant session field #106813

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2023
Merged

Remove redundant session field #106813

merged 1 commit into from
Jan 14, 2023

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 13, 2023

There was already a session available in the resolver, so we access that session.

@oli-obk oli-obk added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Jan 13, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 13, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 13, 2023
@GuillaumeGomez
Copy link
Member

Good catch, thanks! Do you think it's worth a perf run? If not just r=me.

@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 13, 2023

I don't believe this will affect perf

@bors r=GuillaumeGomez rollup

@bors
Copy link
Collaborator

bors commented Jan 13, 2023

📌 Commit 67f8afd1064c753cd6ea14e2a4b7c53637832309 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2023
@petrochenkov
Copy link
Contributor

@bors r-
Could you add a pub fn sess() getter instead of using a public field?
Resolver doesn't currently have any public fields.
r? @petrochenkov

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 13, 2023
@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 13, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 13, 2023
@petrochenkov
Copy link
Contributor

@bors r=GuillaumeGomez,petrochenkov

@bors
Copy link
Collaborator

bors commented Jan 13, 2023

📌 Commit 4aca7be has been approved by GuillaumeGomez,petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 13, 2023
@matthiaskrgr
Rollup merge of rust-lang#106813 - oli-obk:sess_cleanup, r=GuillaumeG…
213b4cf 
…omez,petrochenkov

Remove redundant session field

There was already a session available in the resolver, so we access that session.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 13, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 13, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 13, 2023
@bors
Auto merge of rust-lang#106822 - matthiaskrgr:rollup-46bi4pi, r=matth…
a11eb4f 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#104645 (Add log-backtrace option to show backtraces along with logging)
 - rust-lang#106465 (Bump `IMPLIED_BOUNDS_ENTAILMENT` to Deny + ReportNow)
 - rust-lang#106489 (Fix linker detection for linker (drivers) with a version postfix (e.g. clang-12 instead of clang))
 - rust-lang#106585 (When suggesting writing a fully qualified path probe for appropriate types)
 - rust-lang#106641 (Provide help on closures capturing self causing borrow checker errors)
 - rust-lang#106678 (Warn when using panic-strategy abort for proc-macro crates)
 - rust-lang#106701 (Fix `mpsc::SyncSender` spinning behavior)
 - rust-lang#106793 (Normalize test output more thoroughly)
 - rust-lang#106797 (riscv: Fix ELF header flags)
 - rust-lang#106813 (Remove redundant session field)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f709382 into rust-lang:master Jan 14, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 14, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@petrochenkov petrochenkov

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@oli-obk @rustbot @GuillaumeGomez @bors @petrochenkov