Skip to content

Deprioritize fulfillment errors that come from expansions. #106820

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2023
Merged

Deprioritize fulfillment errors that come from expansions. #106820

merged 1 commit into from
Jan 15, 2023

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Jan 13, 2023

Fixes (part of?) #69455

@m-ou-se m-ou-se added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 13, 2023
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2023
@m-ou-se m-ou-se mentioned this pull request Jan 13, 2023
Closed
@m-ou-se m-ou-se force-pushed the macro-type-error-thing branch from 62b5084 to 40a175d Compare January 13, 2023 17:56
@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 13, 2023

📌 Commit 40a175dff787ffbae28c3538bb0c43e5a9d2c1f8 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2023
@compiler-errors
Copy link
Member

@bors r- looks like a test ICE

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 13, 2023
@m-ou-se
Copy link
Member Author

m-ou-se commented Jan 13, 2023

That error is the async.stderr thing.

@estebank said:

don't include the async.stderr file, that's an ongoing issue I've noticed, faulty test someone else is fixing

I suppose this PR is blocked until that is fixed.

@m-ou-se m-ou-se added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 13, 2023
@estebank
Copy link
Contributor

Yeah, it doesn't seem like it would be your PR causing the error in tests/ui/chalkify/bugs/async.rs. I'm seeing different issues with that test (the output is non-deterministic across machines) though.

@compiler-errors
Copy link
Member

Well #106793 is landed, so I think this PR is ready for a bless and r+

@rust-log-analyzer

This comment has been minimized.

# to view
@m-ou-se m-ou-se force-pushed the macro-type-error-thing branch from 40a175d to 6821adb Compare January 14, 2023 13:08
@m-ou-se
Copy link
Member Author

m-ou-se commented Jan 14, 2023

@bors r=estebank

@bors
Copy link
Collaborator

bors commented Jan 14, 2023

📌 Commit 6821adb has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 14, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2023
@bors
Auto merge of rust-lang#106866 - matthiaskrgr:rollup-r063s44, r=matth…
afaf3e0 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#105526 (libcore: make result of iter::from_generator Clone)
 - rust-lang#106563 (Fix `unused_braces` on generic const expr macro call)
 - rust-lang#106661 (Stop probing for statx unless necessary)
 - rust-lang#106820 (Deprioritize fulfillment errors that come from expansions.)
 - rust-lang#106828 (rustdoc: remove `docblock` class from notable trait popover)
 - rust-lang#106849 (Allocate one less vec while parsing arrays)
 - rust-lang#106855 (rustdoc: few small cleanups)
 - rust-lang#106860 (Remove various double spaces in the libraries.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f04f97c into rust-lang:master Jan 15, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 15, 2023
@m-ou-se m-ou-se deleted the macro-type-error-thing branch January 17, 2023 18:44
@m-ou-se m-ou-se mentioned this pull request Jan 20, 2023
Open
50 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
A-diagnostics Area: Messages for errors, warnings, and lints S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
6 participants
@m-ou-se @estebank @bors @compiler-errors @rust-log-analyzer @rustbot