Make const/fn return params more suggestable #106887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
commented
Jan 14, 2023
oli-obk
reviewed
Jan 16, 2023
compiler-errors
force-pushed
the
suggest-types-more
branch
2 times, most recently
from
9744e8a to
42bec5d
Compare
|
☔ The latest upstream changes (presumably #107052) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
suggest-types-more
branch
from
42bec5d to
8a17f5c
Compare
|
☔ The latest upstream changes (presumably #107055) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
suggest-types-more
branch
from
8a17f5c to
31b9cc1
Compare
This comment has been minimized.
This comment has been minimized.
|
r=me with CI happy |
compiler-errors
force-pushed
the
suggest-types-more
branch
from
31b9cc1 to
0b5941a
Compare
|
@bors r=oli-obk |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 0b5941a with merge f6172b4208e1ca8fa057dff994a4a3988c4f23d8... |
|
@bors retry yield to rollup |
|
⌛ Testing commit 0b5941a with merge e55baa55a9e8b117757cde640976f2201d9c9dc8... |
|
@bors retry yield to rollup again! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 3, 2023
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#106887 (Make const/fn return params more suggestable) - rust-lang#107519 (Add type alias for raw OS errors) - rust-lang#107551 ( Replace `ConstFnMutClosure` with const closures ) - rust-lang#107595 (Retry opening proc-macro DLLs a few times on Windows.) - rust-lang#107615 (Replace nbsp in all rustdoc code blocks) - rust-lang#107621 (Intern external constraints in new solver) - rust-lang#107631 (loudly tell people when they change `Cargo.lock`) - rust-lang#107632 (Clarifying that .map() returns None if None.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps const item type suggestions to MachineApplicable (fixes #106843), also replaces FnDef with FnPtr items in return type suggestions to make more things suggestable.
r? diagnostics