Skip to content

ConstBlocks are poly if their substs are poly #106949

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2023
Merged

ConstBlocks are poly if their substs are poly #106949

merged 2 commits into from
Jan 17, 2023

Conversation

compiler-errors
Copy link
Member

r? @BoxyUwU

fixes #106926

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 16, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2023

Some changes occured in rustc_ty_utils::consts.rs

cc @BoxyUwU

@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 16, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 16, 2023

📌 Commit fdaac4e has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2023
@BoxyUwU BoxyUwU added the A-const-generics Area: const generics (parameters and arguments) label Jan 16, 2023
@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 16, 2023

@bors r- manual rollup go brrr

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 16, 2023
@rustbot rustbot added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Jan 16, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2023

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@compiler-errors
Copy link
Member Author

fixed "generic constant" pluralization

@bors r=BoxyUwU

@bors
Copy link
Collaborator

bors commented Jan 16, 2023

📌 Commit 9f6fef9 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 16, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2023
@bors
Auto merge of rust-lang#106966 - matthiaskrgr:rollup-e34pevi, r=matth…
85357e3 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#106591 (suggestion for attempted integer identifier in patterns)
 - rust-lang#106712 (make error emitted on `impl &Trait` nicer)
 - rust-lang#106829 (Unify `Opaque`/`Projection` handling in region outlives code)
 - rust-lang#106869 (rustdoc: remove redundant item kind class from `.item-decl > pre`)
 - rust-lang#106949 (ConstBlocks are poly if their substs are poly)
 - rust-lang#106953 (Document `EarlyBinder::subst_identity` and `skip_binder`)
 - rust-lang#106958 (Don't add A-bootstrap to PRs modifying Cargo.lock)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9bcc46e into rust-lang:master Jan 17, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 17, 2023
@Alexendoo Alexendoo mentioned this pull request Jan 18, 2023
Closed
@compiler-errors compiler-errors deleted the is-poly branch August 11, 2023 20:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@BoxyUwU BoxyUwU

Labels
A-const-generics Area: const generics (parameters and arguments) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

[ICEs]: generic_const_exprs
4 participants
@compiler-errors @rustbot @BoxyUwU @bors