Detect references to non-existant messages in Fluent resources #107096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nilstrieb (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-translation
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
clubby789
force-pushed
the
fluent-bad-messageref
branch
from
dbf751e to
9d9b242
Compare
This comment has been minimized.
This comment has been minimized.
|
@clubby789, is it possible for you to commit a test for this? Maybe with a bad fluent file in https://github.com/rust-lang/rust/tree/master/tests/run-make/translation ? |
clubby789
force-pushed
the
fluent-bad-messageref
branch
from
9d9b242 to
22e34ce
Compare
|
Added the test to |
This comment has been minimized.
This comment has been minimized.
clubby789
force-pushed
the
fluent-bad-messageref
branch
2 times, most recently
from
4c99ac9 to
e8d335d
Compare
|
☔ The latest upstream changes (presumably #107187) made this pull request unmergeable. Please resolve the merge conflicts. |
clubby789
force-pushed
the
fluent-bad-messageref
branch
from
e8d335d to
bd43c07
Compare
clubby789
force-pushed
the
fluent-bad-messageref
branch
from
bd43c07 to
89b1f39
Compare
|
Something like #92565 would help to generate nicer diagnostics but a reference to the file/offending messages is probably the best we can do for now |
|
I'm happy with this as-is. Thanks for implementing this! @bors r+ |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 27, 2023
…=compiler-errors Detect references to non-existant messages in Fluent resources Should help with cases like rust-lang#107091, where `{variable}` (a message reference) is accidentally typed, rather than `{$variable}` (a variable reference) `@rustbot` label +A-translation
|
Failed in rollup: #107341 (comment) |
bors
added
S-waiting-on-author
clubby789
force-pushed
the
fluent-bad-messageref
branch
from
89b1f39 to
0ae0d87
Compare
|
HashMap -> Vec to avoid query instability |
rustbot
added
S-waiting-on-review
Closed
4 tasks
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 27, 2023
…=compiler-errors Detect references to non-existant messages in Fluent resources Should help with cases like rust-lang#107091, where `{variable}` (a message reference) is accidentally typed, rather than `{$variable}` (a variable reference) Fixes rust-lang#107370 `@rustbot` label +A-translation
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 28, 2023
…=compiler-errors Detect references to non-existant messages in Fluent resources Should help with cases like rust-lang#107091, where `{variable}` (a message reference) is accidentally typed, rather than `{$variable}` (a variable reference) Fixes rust-lang#107370 ``@rustbot`` label +A-translation
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 28, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#104012 (Improve unexpected close and mismatch delimiter hint in TokenTreesReader) - rust-lang#104252 (Stabilize the const_socketaddr feature) - rust-lang#105524 (Replace libc::{type} with crate::ffi::{type}) - rust-lang#107096 (Detect references to non-existant messages in Fluent resources) - rust-lang#107355 (Add regression test for rust-lang#60755) - rust-lang#107384 (Remove `BOOL_TY_FOR_UNIT_TESTING`) - rust-lang#107385 (Use `FallibleTypeFolder` for `ConstInferUnifier` not `TypeRelation`) - rust-lang#107391 (rustdoc: remove inline javascript from copy-path button) - rust-lang#107398 (Remove `ControlFlow::{BREAK, CONTINUE}`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 10, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#104012 (Improve unexpected close and mismatch delimiter hint in TokenTreesReader) - rust-lang#104252 (Stabilize the const_socketaddr feature) - rust-lang#105524 (Replace libc::{type} with crate::ffi::{type}) - rust-lang#107096 (Detect references to non-existant messages in Fluent resources) - rust-lang#107355 (Add regression test for rust-lang#60755) - rust-lang#107384 (Remove `BOOL_TY_FOR_UNIT_TESTING`) - rust-lang#107385 (Use `FallibleTypeFolder` for `ConstInferUnifier` not `TypeRelation`) - rust-lang#107391 (rustdoc: remove inline javascript from copy-path button) - rust-lang#107398 (Remove `ControlFlow::{BREAK, CONTINUE}`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with cases like #107091, where
{variable}(a message reference) is accidentally typed, rather than{$variable}(a variable reference)Fixes #107370
@rustbot label +A-translation