Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix def-use dominance check #107097

Merged
merged 1 commit into from
Jan 29, 2023
Merged

Fix def-use dominance check #107097

merged 1 commit into from
Jan 29, 2023

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jan 20, 2023

A definition does not dominate a use in the same statement. For example
in MIR generated for compound assignment x += a (when overflow checks
are disabled).

@rustbot
Copy link
Collaborator

rustbot commented Jan 20, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 20, 2023
@tmiasko tmiasko marked this pull request as draft January 20, 2023 01:18
@rust-log-analyzer

This comment has been minimized.

@tmiasko tmiasko force-pushed the ssa branch 2 times, most recently from 9e789a4 to 510cbd3 Compare January 22, 2023 18:32
@tmiasko tmiasko marked this pull request as ready for review January 22, 2023 18:34
@tmiasko
Copy link
Contributor Author

tmiasko commented Jan 22, 2023

Based on #107085, but other than that should be ready for review.

cc @cjgillot (potentially relevant to your recent pull requests)

@bors
Copy link
Collaborator

bors commented Jan 26, 2023

☔ The latest upstream changes (presumably #107328) made this pull request unmergeable. Please resolve the merge conflicts.

A definition does not dominate a use in the same statement. For example
in MIR generated for compound assignment x += a (when overflow checks
are disabled).
@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 28, 2023

📌 Commit e489971 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#106618 (Disable `linux_ext` in wasm32 and fortanix rustdoc builds.)
 - rust-lang#107097 (Fix def-use dominance check)
 - rust-lang#107154 (library/std/sys_common: Define MIN_ALIGN for m68k-unknown-linux-gnu)
 - rust-lang#107397 (Gracefully exit if --keep-stage flag is used on a clean source tree)
 - rust-lang#107401 (remove the usize field from CandidateSource::AliasBound)
 - rust-lang#107413 (make more pleasant to read)
 - rust-lang#107422 (Also erase substs for new infcx in pin move error)
 - rust-lang#107425 (Check for missing space between fat arrow and range pattern)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4caa9df into rust-lang:master Jan 29, 2023
@rustbot rustbot added this to the 1.69.0 milestone Jan 29, 2023
@tmiasko tmiasko deleted the ssa branch January 29, 2023 11:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants