Skip to content

Small bootstrap improvements #107470

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Small bootstrap improvements #107470

merged 3 commits into from
Feb 1, 2023

Conversation

kadiwa4
Copy link
Contributor

@kadiwa4 kadiwa4 commented Jan 30, 2023

  • i/o-less check for xz availability
  • cache result of NixOS detection
  • load correct bootstrap module even when a package of that name is installed
  • no -W semicolon_in_expressions_from_macros – it is warn-by-default
  • one type per variable (making dynamic typing less confusing)
  • integrate python-side --help flag into the argument parser (makes -hv work as a short form of --help --verbose)

I even checked that it works with Python 2.

@rustbot
Copy link
Collaborator

rustbot commented Jan 30, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 30, 2023
@jyn514
Copy link
Member

jyn514 commented Jan 30, 2023

cache result of NixOS detection

Could you please do that in the Rust code too?

@jyn514 jyn514 changed the title Small bootstrap improvements Small bootstrap.py improvements Jan 30, 2023
@albertlarsan68
Copy link
Member

cache result of NixOS detection

Could you please do that in the Rust code too?

It was already done

@albertlarsan68 albertlarsan68 changed the title Small bootstrap.py improvements Small bootstrap improvements Jan 30, 2023
@kadiwa4 kadiwa4 force-pushed the bootstrap_cleanup branch 2 times, most recently from ede90ef to a21cc21 Compare January 30, 2023 16:36
@albertlarsan68
Copy link
Member

Thanks for your work!
@bors r+

@bors
Copy link
Collaborator

bors commented Jan 31, 2023

📌 Commit 043c634 has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 1, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#107389 (Fixing confusion between mod and remainder)
 - rust-lang#107442 (improve panic message for slice windows and chunks)
 - rust-lang#107470 (Small bootstrap improvements)
 - rust-lang#107487 (Make the "extra if in let...else block" hint a suggestion)
 - rust-lang#107499 (Do not depend on Generator trait when deducing closure signature)
 - rust-lang#107533 (Extend `-Z print-type-sizes` to distinguish generator upvars+locals from "normal" fields.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b853b22 into rust-lang:master Feb 1, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 1, 2023
@kadiwa4 kadiwa4 deleted the bootstrap_cleanup branch February 1, 2023 10:45
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 9, 2023
…bertlarsan68

bootstrap.py: fix build-failure message

A small mistake I did.
Corrects rust-lang#107470, fixes rust-lang#107804

r? `@albertlarsan68` (since you reviewed the last one)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants