Use ObligationCtxt::new_in_snapshot in satisfied_from_param_env
#107479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in cc @BoxyUwU |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
BoxyUwU
added
the
A-const-generics
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 31, 2023
Rollup of 8 pull requests Successful merges: - rust-lang#107245 (Implement unsizing in the new trait solver) - rust-lang#107445 (Remove `GenFuture` from core) - rust-lang#107473 (Update books) - rust-lang#107476 (rustdoc: remove unnecessary wrapper `div.item-decl` from HTML) - rust-lang#107477 (Migrate last part of CSS themes to CSS variables) - rust-lang#107479 (Use `ObligationCtxt::new_in_snapshot` in `satisfied_from_param_env`) - rust-lang#107482 (rustdoc: remove meta keywords from HTML) - rust-lang#107494 (fix link in std::path::Path::display()) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can evaluate nested
ConstEvaluatableobligations in an evaluation probe, which will ICE if we useObligationCtxt::new.Fixes #107474
Fixes #106666
r? @BoxyUwU but feel free to reassign
cc @JulianKnodt who i think added this assertion code
Not sure if the rustdoc test is needed, but can't hurt. They're the same root cause, though.