Add nicer output to PGO build timer #107596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
@bors try |
|
⌛ Trying commit 7f9cfce with merge 265c55e4d2aa98b3dee46d23cb6c0b25a7f58d20... |
|
☀️ Try build successful - checks-actions |
1 similar comment
|
☀️ Try build successful - checks-actions |
|
This is how the new format looks like: |
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 6, 2023
…imulacrum Add nicer output to PGO build timer This PR modifies the timer used in the PGO build script to contain nicer, hierarchical output of the individual build steps. It's not trivial to test locally, so I'll fire up a dist build right away. r? `@Mark-Simulacrum`
This was referenced Feb 6, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 6, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#106477 (Refine error spans for "The trait bound `T: Trait` is not satisfied" when passing literal structs/tuples) - rust-lang#107596 (Add nicer output to PGO build timer) - rust-lang#107692 (Sort Generator `print-type-sizes` according to their yield points) - rust-lang#107714 (Clarify wording on f64::round() and f32::round()) - rust-lang#107720 (end entry paragraph with a period (.)) - rust-lang#107724 (remove unused rustc_* imports) - rust-lang#107725 (Turn MarkdownWithToc into a struct with named fields) - rust-lang#107731 (interpret: move discriminant reading and writing to separate file) - rust-lang#107735 (Add mailmap for commits made by xes@meta.com) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the timer used in the PGO build script to contain nicer, hierarchical output of the individual build steps. It's not trivial to test locally, so I'll fire up a dist build right away.
r? @Mark-Simulacrum