Skip to content

Don't recover lifetimes/labels containing emojis as character literals #108031

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2023
Merged

Don't recover lifetimes/labels containing emojis as character literals #108031

merged 3 commits into from
Feb 18, 2023

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Feb 14, 2023 •
edited
Loading

Fixes #108019.

Note that at the time of this commit, unic-emoji-char seems to have data tables only up to Unicode 5.0, but Unicode is already newer than this.

A newer emoji such as 🥺 will not be recognized as an emoji but older emojis such as 🐱 will.

This PR leaves a couple of FIXMEs where unic_emoji_char::is_emoji is used.

@jieyouxu
Don't recover lifetimes/labels containing emojis as character literals
380fa26 
Note that at the time of this commit, `unic-emoji-char` seems to have
data tables only up to Unicode 5.0, but Unicode is already newer than
this.

A newer emoji such as `🥺` will not be recognized as an emoji
but older emojis such as `🐱` will.
@rustbot
Copy link
Collaborator

rustbot commented Feb 14, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 14, 2023
@rust-log-analyzer

This comment has been minimized.

# to view
@rust-log-analyzer

This comment has been minimized.

# to view
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 17, 2023

📌 Commit e3f9db5 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2023
@estebank
Copy link
Contributor

r? @estebank

@rustbot rustbot assigned estebank and unassigned jackh726 Feb 17, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 18, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 18, 2023
@bors
Auto merge of rust-lang#108211 - matthiaskrgr:rollup-e59onmm, r=matth…
3eb5c45 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#108031 (Don't recover lifetimes/labels containing emojis as character literals)
 - rust-lang#108046 (Don't allow evaluating queries that were fed in a previous compiler run)
 - rust-lang#108162 (Don't eagerly convert principal to string)
 - rust-lang#108186 (Deny non-lifetime bound vars in `for<..> ||` closure binders)
 - rust-lang#108197 (Update cargo)
 - rust-lang#108205 (link to llvm changes that prompted the special cases)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3035ccb into rust-lang:master Feb 18, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 18, 2023
@jieyouxu jieyouxu deleted the issue-108019 branch February 18, 2023 17:02
@ehuss ehuss mentioned this pull request Mar 30, 2023
Closed
@apiraino apiraino mentioned this pull request Mar 30, 2023
Closed
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Apr 10, 2023
@compiler-errors
Revert "Don't recover lifetimes/labels containing emojis as character…
a047064 
… literals"

Reverts PR rust-lang#108031
Fixes (doesnt close until beta backported) rust-lang#109746

This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.
@compiler-errors compiler-errors mentioned this pull request Apr 10, 2023
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 10, 2023
@Dylan-DPC
Rollup merge of rust-lang#110135 - compiler-errors:revert-108031, r=d…
0aea6c0 
…avidtwco

Revert "Don't recover lifetimes/labels containing emojis as character literals"

Reverts PR rust-lang#108031 per rust-lang#109754 (comment)

Fixes (doesnt close until beta backported) rust-lang#109746

This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Apr 11, 2023
@JohnTitor
Rollup merge of rust-lang#110135 - compiler-errors:revert-108031, r=d…
296ac2e 
…avidtwco

Revert "Don't recover lifetimes/labels containing emojis as character literals"

Reverts PR rust-lang#108031 per rust-lang#109754 (comment)

Fixes (doesnt close until beta backported) rust-lang#109746

This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 11, 2023
@Dylan-DPC
Rollup merge of rust-lang#110135 - compiler-errors:revert-108031, r=d…
d64cfdf 
…avidtwco

Revert "Don't recover lifetimes/labels containing emojis as character literals"

Reverts PR rust-lang#108031 per rust-lang#109754 (comment)

Fixes (doesnt close until beta backported) rust-lang#109746

This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Apr 11, 2023
@compiler-errors
Rollup merge of rust-lang#110135 - compiler-errors:revert-108031, r=d…
b56deeb 
…avidtwco

Revert "Don't recover lifetimes/labels containing emojis as character literals"

Reverts PR rust-lang#108031 per rust-lang#109754 (comment)

Fixes (doesnt close until beta backported) rust-lang#109746

This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 12, 2023
@matthiaskrgr
Rollup merge of rust-lang#110135 - compiler-errors:revert-108031, r=d…
57393be 
…avidtwco

Revert "Don't recover lifetimes/labels containing emojis as character literals"

Reverts PR rust-lang#108031 per rust-lang#109754 (comment)

Fixes (doesnt close until beta backported) rust-lang#109746

This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.
bors pushed a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2023
@compiler-errors @pietroalbini
Revert "Don't recover lifetimes/labels containing emojis as character…
6ed03e8 
… literals"

Reverts PR rust-lang#108031
Fixes (doesnt close until beta backported) rust-lang#109746

This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.
MabezDev pushed a commit to esp-rs/rust that referenced this pull request May 16, 2023
@compiler-errors @MabezDev
Revert "Don't recover lifetimes/labels containing emojis as character…
3e22715 
… literals"

Reverts PR rust-lang#108031
Fixes (doesnt close until beta backported) rust-lang#109746

This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.

Emoji in label/lifetime recovered as character literal (rather than identifier)
6 participants
@jieyouxu @rustbot @rust-log-analyzer @estebank @bors @jackh726